Ticket #7925 (closed defect (bug): fixed)

Opened 3 years ago

Last modified 3 years ago

update_post_meta() and delete_post_meta() not using wp_is_post_revision() on $post_id, resulting in multiple meta rows and incorrect return values

Reported by: misterbisson Owned by: markjaquith
Priority: normal Milestone: 2.7
Component: General Version:
Severity: normal Keywords: post_meta
Cc:

Description

add_post_meta() uses the following block of code to make sure the passed $post_id is a real post, not a revision: `

make sure meta is added to the post, not a revision if ( $the_post = wp_is_post_revision($post_id) )

$post_id = $the_post;

`

However, update_post_meta() and delete_post_meta() do not do that. The bug is present in trunk.

Attachments

post.php.diff Download (800 bytes) - added by misterbisson 3 years ago.

Change History

I guess i needed some practice setting file extensions and attaching files. Please delete all but the last.

  • Owner changed from anonymous to markjaquith
  • Status changed from new to assigned
  • Milestone changed from 2.8 to 2.7

Thanks for this! I've seen this in action but couldn't figure out what was going on.

  • Status changed from assigned to closed
  • Resolution set to fixed

(In [9252]) Update update_post_meta() and delete_post_meta() to work with post revisions. Props misterbisson. fixes #7925

(In [9743]) Update update_post_meta() and delete_post_meta() to work with post revisions. Props misterbisson. fixes #7925 for 2.6.x

Note: See TracTickets for help on using tickets.