Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#8166 closed enhancement (fixed)

Optimizations for mysql2date()

Reported by: jacobsantos Owned by: anonymous
Priority: normal Milestone: 2.8
Component: Optimization Version:
Severity: normal Keywords: phpdoc has-patch tested commit
Cc:

Description

Optimizations for mysql2date().

  1. Might be premature, but first patch at least removes redundant code.
  2. Second patch needs testing, but might speed up code while simpflying it.

Based on Speedboxer suggestion and discussion with DD32 on IRC.

Attachments (2)

8166.r9626.diff​ (2.2 KB) - added by jacobsantos 5 years ago.
First patch which removes redundant code (DRY), based on r9626
8166.r9626.2.diff​ (2.7 KB) - added by jacobsantos 5 years ago.
Second patch for optimizating mysql2time() based on r9626

Download all attachments as: .zip

Change History (8)

jacobsantos — 5 years ago

First patch which removes redundant code (DRY), based on r9626

jacobsantos — 5 years ago

Second patch for optimizating mysql2time() based on r9626

comment:1   jacobsantos — 5 years ago

  • Keywords has-patch added

comment:2   Speedboxer — 5 years ago

Tested the second patch, it works.

comment:3   jacobsantos — 4 years ago

  • Keywords tested commit added

comment:4   westi — 4 years ago

Liking the ammount of red in the diff.

Lets throw this in trunk

comment:5   westi — 4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [10408]) Reduce code in mysql2date. Fixes #8166 props jacobsantos

comment:6   lloydbudd — 4 years ago

Caused #9035

Note: See TracTickets for help on using tickets.