WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

#8268 closed enhancement (wontfix)

Apply image_downsize filter before wp_attachment_is_image check in image_downsize function

Reported by: jbrinley Owned by:
Priority: normal Milestone: 2.9
Component: Gallery Version: 2.7
Severity: normal Keywords: has-patch
Cc: jbrinley

Description

The function image_downsize in wp-include/media.php calls wp_attachment_is_image, which must return true before applying the image_downsize filter. By moving the call to the image_downsize filter to the beginning of the function, plugins (let's say, for example, the ​Custom Thumbnails plugin) can return representations of non-image media.

The only possible negative consequence that I can see: plugin writers can't assume that the image_downsize filter will only be called for images (but I don't know that they should assume that, anyway).

Attachments (1)

image_downsize.diff​ (862 bytes) - added by jbrinley 5 years ago.
Patch for image_downsize in wp-includes/media.php

Download all attachments as: .zip

Change History (6)

jbrinley — 5 years ago

Patch for image_downsize in wp-includes/media.php

comment:1 Denis-de-Bernardy — 4 years ago

  • Keywords dev-feedback added

+1

comment:2 janeforshort — 4 years ago

  • Milestone changed from 2.8 to 2.9

Punting due to time constraints. Media changes planned for 2.9/3.0.

comment:3 Denis-de-Bernardy — 4 years ago

a very similar ticket that got closed a week ago or so: #9672

comment:4 Denis-de-Bernardy — 4 years ago

  • Keywords dev-feedback removed

comment:5 janeforshort — 4 years ago

  • Resolution set to wontfix
  • Status changed from new to closed

Closing due to lack of traction. Can be reopened if anyone wants to passionately advocate for it.

Note: See TracTickets for help on using tickets.