Ticket #8581 (closed defect (bug): fixed)

Opened 3 years ago

Last modified 3 years ago

Tag not closed in theme editor when the file does not have a description

Reported by: roganty Owned by: roganty
Priority: normal Milestone: 2.7.1
Component: UI Version: 2.7
Severity: normal Keywords: has-patch theme editor ui xhtml
Cc:

Description

I've noticed this before problem before, but I didn't think anything of it.

The problem is to do when the file being edited doesn't have a description, the strong tag is not closed in the title.

There are two ways this could be fixed, but they both give different results.

The first way is to add the opening strong tag to the start of the variable $desc_header and to remove the opening strong tag from where the variable is printed to the screen.
If there is no description this fix will not make the file name bold.

The second way is to add the closing strong tag to the end of the variable $desc_header
If there is no description this fix will make the file name bold.

Attachments

theme-editor1.diff Download (728 bytes) - added by roganty 3 years ago.
Closes tag and removes formatting from file name with no description
theme-editor2.diff Download (484 bytes) - added by roganty 3 years ago.
Closes tag and keeps formatting for file name with no description

Change History

roganty3 years ago

Closes tag and removes formatting from file name with no description

roganty3 years ago

Closes tag and keeps formatting for file name with no description

  • Version set to 2.7
  • Status changed from new to closed
  • Resolution set to fixed

(In [10194]) Fix missing closing tag in theme-editor.php, props roganty, fixes #8581

comment:3   ryan3 years ago

  • Milestone changed from 2.8 to 2.7.1

comment:4   ryan3 years ago

(In [10195]) Fix missing closing tag in theme-editor.php, props roganty, fixes #8581 for 2.7

Note: See TracTickets for help on using tickets.