Ticket #8583 (closed defect (bug): fixed)

Opened 3 years ago

Last modified 3 years ago

If you're using paged coments, 'first' is selected in the options and wp_list_comments is used, then the comment permalinks on the first page will be broken

Reported by: johnconners Owned by:
Priority: normal Milestone: 2.7.1
Component: Comments Version: 2.7
Severity: normal Keywords:
Cc:

Description

Basically, if this set of circumstances is true then the individual comment permalinks will look like this on the first page:

 http://localhost/wptrunk/2008/12/this-is-a-post/comment-page-/#comment-12345

Note that the number '1' should appear after 'comment-page-', since it's page 1. This happens since the 'cpage' query parameter isn't set for the first page of comments unless the option to show the latest comments by default is set.

Attached is a patch that fixes the problem.

Attachments

8583.diff Download (663 bytes) - added by johnconners 3 years ago.

Change History

comment:1   ryan3 years ago

  • Status changed from new to closed
  • Resolution set to fixed

(In [10196]) Fix comment links when displaying first page of comments. Props johnconners. fixes #8583 for trunk

comment:2   ryan3 years ago

  • Milestone changed from 2.8 to 2.7.1

comment:3   ryan3 years ago

(In [10197]) Fix comment links when displaying first page of comments. Props johnconners. fixes #8583 for 2.7

Dang, I thought I tested my bit of code to death. Sorry that slipped in.

  • Keywords has-patch removed
  • Status changed from closed to reopened
  • Resolution fixed deleted

If you change the number of comments per page with 'wp_list_comments' the first paginate_comments_links function ABOVE the comments isn't aware of it and is shown.

This is a real problem if newest option is choosen because the user has to switch to the second page before seeing any links at all.

  • Status changed from reopened to closed
  • Resolution set to fixed

Please open a new ticket rather than reopening this ticket. Your issue is unrelated to this one.

Note: See TracTickets for help on using tickets.