Tag cloud order priority is broken

[brh]

If you specify the order parameter (ASC or DESC) for wp_tag_cloud, you get the opposite ordering you asked for.

On line 654 of category-template.php, there's some code that looks like this:

if ( 'DESC' == $order )

$tags = array_reverse( $tags, true );

But up at line 560, the query that gets the tags always uses DESC. So reversing it gets an ascending order. Line 654 should be changed to "if ( 'ASC' == $order )". Beyond that, having ASC as a default for ordering something on frequency is kind of odd, don't you think?

Tag cloud ordering works for me in 2.7

Try it with these options:

<?php wp_tag_cloud('format=list&orderby=count&order=DESC&number=10'); ?>

You'd expect the most common tags on top, right? You can just look at the code, too - it does a "DESC" ordering in the select, then reverses it if you have the "DESC" order option. Thus it selects the top 10 most popular tags, and then displays them from least popular to most popular.

Category template fixes count order by for trunk

Category template diff fixes count orderby for 2.7

I see what you mean now, I was looking at the default ordering, which is by tag name, and works as expected. Attached fixes orderby COUNT. May need testing.

(In [10316]) Fix ASC/DESC tag ordering by count, props mrmist, fixes #8609 for trunk

(In [10317]) Fix ASC/DESC tag ordering by count, props mrmist, fixes #8609 for 2.7