Ticket #8630 (closed defect (bug): fixed)

Opened 3 years ago

Last modified 3 years ago

Wrong Paged Comments Logic

Reported by: filosofo Owned by: anonymous
Priority: normal Milestone: 2.7.1
Component: General Version: 2.7
Severity: normal Keywords: previous_comments_link next_comments_link cpage comments paged-comments has-patch
Cc:

Description

previous_comments_link and next_comments_link both erroneously assume that an empty cpage query variable value means that the comments page is page 1. This is wrong, because when "last" is the page displayed by default under Settings > Discussion, page 1 is the oldest page of comments, which is not the same as the permalink page (the page where cpage would not be specified, ordinarily).

Fortunately, this doesn't seem to affect anything as there's never any point at which *_comments_link are called but WordPress has not set the cpage query variable.

Attachments

wrong_cpage_numbering.diff Download (545 bytes) - added by filosofo 3 years ago.

Change History

filosofo — 3 years ago

comment:1   ryan — 3 years ago

  • Status changed from new to closed
  • Resolution set to fixed

(In [10277]) Don't assume page 1 when cpage is empty. Props filosofo. fixes #8630 for trunk

comment:2   ryan — 3 years ago

(In [10278]) Don't assume page 1 when cpage is empty. Props filosofo. fixes #8630 for 2.7

Note: See TracTickets for help on using tickets.