Ticket #8704 (closed defect (bug): fixed)

Opened 3 years ago

Last modified 3 years ago

Missing Filter in function wp_get_object_terms()

Reported by: miqrogroove Owned by: ryan
Priority: normal Milestone: 2.8
Component: Taxonomy Version: 2.7
Severity: normal Keywords: has-patch tested commit
Cc:

Description

The qTranslate plugin author has asked me to forward this issue to WP dev.

in wp-includes/taxonomy.php function wp_get_object_terms()

find 

   return $terms;

replace with 

   $terms = apply_filters('wp_get_object_terms', $terms);
   return $terms;

Original discussion at  http://www.qianqin.de/qtranslate/forum/viewtopic.php?f=3&t=305

Enjoy

Attachments

8704.diff Download (472 bytes) - added by Denis-de-Bernardy 3 years ago.

Change History

Denis-de-Bernardy — 3 years ago

comment:1   Denis-de-Bernardy — 3 years ago

  • Keywords has-patch dev-feedback added

patch adds a filter that passes the full set of parameters.

comment:2   Denis-de-Bernardy — 3 years ago

  • Keywords tested added; dev-feedback removed
  • Milestone changed from 2.7.2 to 2.8

comment:3   Denis-de-Bernardy — 3 years ago

see also: #9719 and #9227

comment:4   Denis-de-Bernardy — 3 years ago

  • Keywords commit added

commit, wontfix?

comment:5   westi — 3 years ago

  • Status changed from new to closed
  • Resolution set to fixed

(In [11253]) Add a filter to the result of wp_get_object_terms(). Fixes #8704 props Denis-de-Bernardy.

comment:6 follow-up: ↓ 7   Denis-de-Bernardy — 3 years ago

  • Status changed from closed to reopened
  • Resolution fixed deleted

shouldn't the empty terms list be filtered too, as in the initial patch?

comment:7 in reply to: ↑ 6   westi — 3 years ago

Replying to Denis-de-Bernardy:

shouldn't the empty terms list be filtered too, as in the initial patch?

Thanks for the typo catch.

Bad manual application of the patch :-(

comment:8   westi — 3 years ago

  • Status changed from reopened to closed
  • Resolution set to fixed

(In [11255]) Fix typo in [11253] fixes #8704 props Denis-de-Bernardy.

Note: See TracTickets for help on using tickets.