Context Navigation

← Previous Ticket
Next Ticket →

Ticket #8714 (new enhancement)

Opened 3 years ago

Last modified 5 weeks ago

Ellipses instead of ... in UI

Reported by:	janeforshort	Owned by:
Priority:	normal	Milestone:	3.4
Component:	UI	Version:	2.7
Severity:	trivial	Keywords:	has-patch gsoc
Cc:	wojtek.szkutnik@…, xoodrew@…, gary@…, r_a_m_i@…

Description

In places where we use [...] to indicate that there's more content, we should use ellipses instead of three periods.

Attachments

patch.diff (34.2 KB) - added by tjsingleton 3 years ago.
patch.2.diff (33.3 KB) - added by jordie23 3 years ago.
8714.diff (26.3 KB) - added by wojtek.szkutnik 19 months ago.
8714.2.diff (31.6 KB) - added by DrewAPicture 5 weeks ago.: Mostly standardizes …, some whitespacing in affected blocks

Change History

tjsingleton — 3 years ago

attachment patch.diff added

comment:1 tjsingleton — 3 years ago

grepped for "..." and replaced what I found being outputted with "…"

comment:2 ninjaWR — 3 years ago

Keywords has-patch added

comment:3 ryan — 3 years ago

Line 47 of formatting.php should not change. Some occurrences of ... should be replaced with a period. The ones in wp-login.php, for example. Some error message need to be reworded. "Error in deleting..." for one.

comment:4 coffee2code — 3 years ago

Also, there seems to be a preference for numbered rather than named entities, so ... should probably be replaced with …

comment:5 Denis-de-Bernardy — 3 years ago

Keywords needs-patch added; ellipses has-patch removed
Milestone changed from 2.8 to 2.9

bumping to 2.9, since patch needs to be refreshed

jordie23 — 3 years ago

attachment patch.2.diff added

comment:6 jordie23 — 3 years ago

Keywords has-patch added; needs-patch removed

Similar patch as before, uses numeric entities, ellipses are removed from certain phrases where they shouldn't exist and the 3 periods are left unchanged on line 47 of formatting.php.

comment:7 Denis-de-Bernardy — 3 years ago

Keywords needs-patch added; has-patch removed
Milestone changed from 2.9 to Future Release

comment:8 wojtek.szkutnik — 19 months ago

Cc wojtek.szkutnik@… added
Keywords has-patch gsoc added; needs-patch removed

wojtek.szkutnik — 19 months ago

attachment 8714.diff added

comment:9 RyanMurphy — 17 months ago

Possible for 3.1?

comment:10 jane — 5 weeks ago

Milestone changed from Future Release to 3.4

Is the latest patch good to go? It's embarrassing that this little thing still hasn't been fixed. I didn't mention it in the original ticket, but this flaw was called out by Chris Messina when he was a participant in 2.7 testing.

comment:11 nacin — 5 weeks ago

Ellipses should either be part of a translated string (as many are here), or if used as part of text, should be __( '…' ) for translators. (We currently do '…' for translators, but we can standardize either way.)

comment:12 azaozz — 5 weeks ago

Agreed, best to be either one or the other. Also worth mentioning that we shouldn't use HTML entities in JS strings like the translated strings in script-loader.