Opened 4 years ago
Closed 5 weeks ago
#8714 closed enhancement (fixed)
Ellipses instead of ... in UI
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | 3.6 |
| Component: | Text Changes | Version: | 2.7 |
| Severity: | trivial | Keywords: | has-patch commit |
| Cc: | wojtek.szkutnik@…, xoodrew@…, gary@…, r_a_m_i@… |
Description
In places where we use [...] to indicate that there's more content, we should use ellipses instead of three periods.
Attachments (10)
Change History (49)
tjsingleton
— 4 years ago
comment:1
tjsingleton
— 4 years ago
comment:3
ryan
— 4 years ago
Line 47 of formatting.php should not change. Some occurrences of ... should be replaced with a period. The ones in wp-login.php, for example. Some error message need to be reworded. "Error in deleting..." for one.
comment:4
coffee2code
— 4 years ago
Also, there seems to be a preference for numbered rather than named entities, so ... should probably be replaced with …
comment:5
Denis-de-Bernardy
— 4 years ago
- Keywords needs-patch added; ellipses has-patch removed
- Milestone changed from 2.8 to 2.9
bumping to 2.9, since patch needs to be refreshed
comment:6
jordie23
— 4 years ago
- Keywords has-patch added; needs-patch removed
Similar patch as before, uses numeric entities, ellipses are removed from certain phrases where they shouldn't exist and the 3 periods are left unchanged on line 47 of formatting.php.
comment:7
Denis-de-Bernardy
— 4 years ago
- Keywords needs-patch added; has-patch removed
- Milestone changed from 2.9 to Future Release
comment:8
wojtek.szkutnik
— 3 years ago
- Cc wojtek.szkutnik@… added
- Keywords has-patch gsoc added; needs-patch removed
wojtek.szkutnik
— 3 years ago
comment:9
RyanMurphy
— 3 years ago
Possible for 3.1?
comment:10
jane
— 18 months ago
- Milestone changed from Future Release to 3.4
Is the latest patch good to go? It's embarrassing that this little thing still hasn't been fixed. I didn't mention it in the original ticket, but this flaw was called out by Chris Messina when he was a participant in 2.7 testing.
comment:11
nacin
— 18 months ago
Ellipses should either be part of a translated string (as many are here), or if used as part of text, should be __( '…' ) for translators. (We currently do '…' for translators, but we can standardize either way.)
comment:12
azaozz
— 18 months ago
Agreed, best to be either one or the other. Also worth mentioning that we shouldn't use HTML entities in JS strings like the translated strings in script-loader.
comment:13
SergeyBiryukov
— 18 months ago
- Keywords needs-refresh added
comment:14
follow-up:
↓ 19
DrewAPicture
— 18 months ago
- Cc xoodrew@… added
Semi-Related #7098 (attachment:ticket:7098:8230-to-hellip.patch)
Working on a refresh.
comment:15
GaryJ
— 18 months ago
- Cc gary@… added
comment:16
DrewAPicture
— 18 months ago
- Keywords needs-refresh removed
After some discussion in IRC, settled on … over … and '...' as it was already pretty widely used in Core. Refreshed patch attached.
comment:17
ramiy
— 18 months ago
- Cc r_a_m_i@… added
comment:18
nacin
— 15 months ago
- Keywords commit added; gsoc removed
Looks good. We need to audit these though, for context (making sure they aren't escaped, for example).
Should probably avoid changing 8230 to hellip if only to not break all of those strings.
comment:19
in reply to:
↑ 14
ramiy
— 15 months ago
Replying to nacin:
Should probably avoid changing 8230 to hellip if only to not break all of those strings.
Nacin, this ticket was created 3 years ago. I think that if we already addressing the issue, we should fix the 8230 as well.
comment:20
nacin
— 14 months ago
- Keywords needs-refresh added; commit removed
Patch is stale. Can someone refresh it?
SergeyBiryukov
— 14 months ago
comment:21
SergeyBiryukov
— 14 months ago
- Keywords needs-refresh removed
comment:22
ryan
— 14 months ago
- Keywords early added
- Milestone changed from 3.4 to Future Release
comment:23
jane
— 14 months ago
Breaking strings in an update is to be expected when the fix is text related. Since this just got punted again, when it goes in eventually, let's not not water it down.
SergeyBiryukov
— 12 months ago
Fixed a couple of misses in class-wp-xmlrpc-server.php and formatting.php
comment:25
helen
— 6 months ago
- Component changed from UI to Text Changes
- Keywords needs-refresh added; early removed
- Milestone changed from Future Release to 3.6
SergeyBiryukov
— 6 months ago
comment:26
SergeyBiryukov
— 6 months ago
- Keywords needs-refresh removed
Skipped the changes in wp-admin/network.php, didn't look good in the <code> tag.
wp-includes/deprecated.php should probably also be skipped.
comment:27
follow-ups:
↓ 29
↓ 30
markjaquith
— 5 months ago
Agree on skipping wp-includes/deprecated.php.
The ones at the ends of error messages should probably change to single periods (as Ryan noted up at comment 3).
Lastly don't we need to avoid using named entities in an XML context?
comment:28
jane
— 5 months ago
Agreed with no ellipses at the end of error messages.
comment:29
in reply to:
↑ 27
;
follow-up:
↓ 31
ramiy
— 5 months ago
comment:30
in reply to:
↑ 27
GaryJ
— 5 months ago
Replying to markjaquith:
Lastly don't we need to avoid using named entities in an XML context?
For polyglot markup, yes, and note the W3C Recommendation that numbered entities SHOULD use the hexadecimal form when it exists.
comment:31
in reply to:
↑ 29
SergeyBiryukov
— 5 months ago
Replying to ramiy:
Skipping depricated strings will only make more simmilar strings and make the transtation file larger.
The strings in question are not translatable, see lines 1707 and 1734:
http://core.trac.wordpress.org/browser/tags/3.5.1/wp-includes/deprecated.php#L1707
comment:32
DrewAPicture
— 7 weeks ago
8714.7.diff miraculously still applies cleanly. Seems like the consensus is that this should happen early in a cycle so maybe punt (again) to 3.7 early?
comment:33
SergeyBiryukov
— 6 weeks ago
- Keywords 3.7-early added
- Milestone changed from 3.6 to Future Release
comment:34
follow-up:
↓ 35
jenmylo
— 6 weeks ago
It is downright embarrassing that something like this should take us ten versions to do. Chris Messina has mocking rights on me/us for the rest of eternity; I told him back in 2008 that we'd get this fixed before we launched 2.7 (he discovered it during usability testing before beta).
comment:35
in reply to:
↑ 34
Denis-de-Bernardy
— 6 weeks ago
Replying to jenmylo:
It is downright embarrassing that something like this should take us ten versions to do.
*Rubs Eyes*...
*Chokes*...
[Caugh! Caugh!]
*Pinches himself... Looks around...*
Did you actually write that, Jane? :-D
comment:36
SergeyBiryukov
— 6 weeks ago
- Keywords commit added; 3.7-early removed
- Milestone changed from Future Release to 3.6
Moving back to 3.6 per the IRC chat.
SergeyBiryukov
— 6 weeks ago
comment:37
SergeyBiryukov
— 6 weeks ago
Refreshed in 8714.8.diff:
- Skipped deprecated.php and "Hello World" post content.
- Changed the instances in error messages to single periods, per comment:27.
- Used numeric entities in XML content, also per comment:27.
comment:38
SergeyBiryukov
— 6 weeks ago
In 24207:
comment:39
SergeyBiryukov
— 5 weeks ago
- Resolution set to fixed
- Status changed from new to closed
grepped for "..." and replaced what I found being outputted with "…"