Ticket #8715 (closed defect (bug): fixed)

Opened 3 years ago

Last modified 3 years ago

wp_page_menu doesn't seem to get link_before link_after

Reported by: ev3rywh3re Owned by: anonymous
Priority: normal Milestone: 2.7.1
Component: Template Version: 2.7
Severity: normal Keywords: wp_page_menu, has-patch
Cc: thee17

Description

I didn't follow the trail to wp_list_pages to see if it had the same issue, but it seems that link_before and link_after are looking for string variables when they should be looking at the array key value instead. Merry Xmas!

Attachments

post-template.php.diff Download (741 bytes) - added by ev3rywh3re 3 years ago.
Patch use $arg array keys for link_before and link_after in post-template.php

Change History

ev3rywh3re — 3 years ago

Patch use $arg array keys for link_before and link_after in post-template.php

comment:1   thee17 — 3 years ago

  • Cc thee17 added

comment:2   ev3rywh3re — 3 years ago

  • Milestone changed from 2.8 to 2.7.1

Or there is a missing: 

	extract( $args, EXTR_SKIP );

in wp_page_menu.

comment:3   ryan — 3 years ago

  • Status changed from new to closed
  • Resolution set to fixed

(In [10269]) Fix link_before and after args. Props ev3rywh3re. fixes #8715 for trunk

comment:4   ryan — 3 years ago

(In [10270]) Fix link_before and after args. Props ev3rywh3re. fixes #8715 for 2.7

Note: See TracTickets for help on using tickets.