Opened 4 years ago
Closed 4 years ago
#8720 closed defect (bug) (fixed)
Screen icon shown twice on Import page
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | low | Milestone: | 2.9 |
| Component: | UI | Version: | 2.7 |
| Severity: | minor | Keywords: | has-patch, tested |
| Cc: |
Attachments (1)
Change History (9)
- Keywords needs-patch added
- Milestone changed from 2.7.2 to Future Release
- Milestone changed from Future Release to 2.9
- Priority changed from normal to low
- Severity changed from normal to minor
- Keywords has-patch tested 2nd-opinion added; needs-patch removed
Is this not more to do with the screen_icon() calls the precede the headings? The attached patch seems to fix things nicely and I can only find one call to this function in the other importer scripts.
Updating this to a commit candidates - it's a very disheartening situation when seeming good patches are apparently ignored. It does not motivate me to look at more.
Note: See
TracTickets for help on using
tickets.

There are several places where H2s are used both as page title and as subtitle, perhaps we should change the subtitles to H3s.
Also there seem to be few H2s that could either be page titles or subtitles, depending on the different "steps". This happens in few importers, in update core and in plugin update. Since the icon is loaded by a small function in template.php, we could use a global and output it only once per page load.
Perhaps it would be better to have a consistent title (H2 and icon) for all pages that have multiple "steps", then have proper subtitles (H3) for each step.