WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#8745 closed defect (bug) (fixed)

language_attributes always check for 'xhtml', never for 'html'

Reported by: zekrap Owned by: anonymous
Priority: normal Milestone: 2.7.1
Component: Template Version: 2.7
Severity: normal Keywords: language_attributes html xhtml doctype
Cc:

Description

To choose between "lang=" or "xml:lang=", the language_attributes checks both 'html_type' option and doctype received as argument. The bug is that it checks twice whether doctype equals 'xhtml', instead of testing the opposite case.
I made a patch to change the first test (for html-like "lang=" case) to check doctype == 'html' (well, maybe quicker to remove the 'x' than apply a patch, though ;-) ).

Attachments (1)

wrong_html_type.patch​ (577 bytes) - added by zekrap 4 years ago.
Patch to fix this issue

Download all attachments as: .zip

Change History (3)

zekrap — 4 years ago

Patch to fix this issue

comment:1 ryan — 4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [10265]) Fix html doctype check. Props zekrap. fixes #8745 for trunk

comment:2 ryan — 4 years ago

(In [10266]) Fix html doctype check. Props zekrap. fixes #8745 for 2.7

Note: See TracTickets for help on using tickets.