Ticket #8745 (closed defect (bug): fixed)

Opened 3 years ago

Last modified 3 years ago

language_attributes always check for 'xhtml', never for 'html'

Reported by: zekrap Owned by: anonymous
Priority: normal Milestone: 2.7.1
Component: Template Version: 2.7
Severity: normal Keywords: language_attributes html xhtml doctype
Cc:

Description

To choose between "lang=" or "xml:lang=", the language_attributes checks both 'html_type' option and doctype received as argument. The bug is that it checks twice whether doctype equals 'xhtml', instead of testing the opposite case. I made a patch to change the first test (for html-like "lang=" case) to check doctype == 'html' (well, maybe quicker to remove the 'x' than apply a patch, though ;-) ).

Attachments

wrong_html_type.patch Download (577 bytes) - added by zekrap 3 years ago.
Patch to fix this issue

Change History

zekrap — 3 years ago

Patch to fix this issue

comment:1   ryan — 3 years ago

  • Status changed from new to closed
  • Resolution set to fixed

(In [10265]) Fix html doctype check. Props zekrap. fixes #8745 for trunk

comment:2   ryan — 3 years ago

(In [10266]) Fix html doctype check. Props zekrap. fixes #8745 for 2.7

Note: See TracTickets for help on using tickets.