Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#8947 closed defect (bug) (fixed)

optimization for install check

Reported by: Denis-de-Bernardy Owned by: joostdevalk
Priority: low Milestone: 2.8
Component: Optimization Version: 2.7
Severity: minor Keywords: has-patch dev-feedback commit
Cc:

Description

currently, WP runs get_option(siteurl) as an install check, and proceeds to load all option if it isn't. would it not be more meaningful to load options first, and to check if get_option(siteurl) is set after doing so? or are there non-obvious reasons for doing things that way?

Attachments (1)

patch.diff​ (820 bytes) - added by joostdevalk 4 years ago.
Patch

Download all attachments as: .zip

Change History (8)

comment:1   ryan — 4 years ago

Sounds reasonable.

comment:2   joostdevalk — 4 years ago

  • Owner changed from anonymous to joostdevalk

Yes, way smarter, I'll write a patch.

comment:3   joostdevalk — 4 years ago

  • Keywords has-patch added; needs-patch removed

joostdevalk — 4 years ago

Patch

comment:4   ShaneF — 4 years ago

  • Keywords commit added

I tested the patch'; Doesn't kills the server. Code looks fine as well.

comment:5   ryan — 4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

[10958]

comment:6   DD32 — 4 years ago

Is there any reason why the $installed branches couldn't've been replaced simply with get_option()

..Or are there issues with Constant/filter overrides?

comment:7   markjaquith — 4 years ago

(In [10974]) Clean up is_blog_installed(), remove redundant or unnecessary code. see #8947

Note: See TracTickets for help on using tickets.