Ticket #9003 (closed defect (bug): fixed)

Opened 3 years ago

Last modified 3 years ago

Deleting Parent Comment Causes Child Comments To Be Incorrectly Displayed

Reported by: gogoplata Owned by:
Priority: normal Milestone: 2.7.2
Component: Comments Version: 2.7
Severity: normal Keywords: has-patch
Cc:

Description

When comment threading is enabled and a parent comment is deleted it's child comments are incorrectly displayed below all other comments, regardless of the time they were made. Deleting a parent comment should cause child comments to default to no parent and display in the comment list chronologically.

Attachments

9003.diff Download (602 bytes) - added by vladimir_kolesnikov 3 years ago.

Change History

comment:1   mrmist — 3 years ago

  • Keywords needs-patch added
  • Version set to 2.7

Or optionally the "deleted" parent could be replaced by a placeholder, so that the other comments do not lose all their context..

comment:2   vladimir_kolesnikov — 3 years ago

  • Keywords has-patch added; needs-patch removed

Attached is the patch that reassigns all children of the deleted comment to its parent (or 0 if the deleted comment is a top level one).

vladimir_kolesnikov — 3 years ago

comment:3   ryan — 3 years ago

  • Status changed from new to closed
  • Resolution set to fixed

(In [10762]) Reparent children when deleting a comment. Props vladimir_kolesnikov. fixes #9003

comment:4   ryan — 3 years ago

(In [10763]) Reparent children when deleting a comment. Props vladimir_kolesnikov. fixes #9003 for 2.7

Note: See TracTickets for help on using tickets.