Ticket #9111 (closed defect (bug): fixed)

Opened 3 years ago

Last modified 3 years ago

Use short versions of ngettext functions

Reported by: nbachiyski Owned by: nbachiyski
Priority: normal Milestone: 2.8
Component: I18N Version: 2.7
Severity: minor Keywords: has-patch tested
Cc:

Description

Use _n instead of _ngettext and _n_noop instead of __ngettext_noop.

Attachments

deprecate-longer-ngettext-functions.diff Download (3.2 KB) - added by nbachiyski 3 years ago.
shorter-ngettext-calls.diff Download (43.5 KB) - added by nbachiyski 3 years ago.

Change History

comment:1   nbachiyski — 3 years ago

A patch to mark the longer alternatives as deprecated. They still work correctly.

nbachiyski — 3 years ago

comment:2   ryan — 3 years ago

  • Status changed from new to closed
  • Resolution set to fixed

(In [10584]) Switch to pomo lib. Support gettext contexts. Deprecate long form functions. Props nbachiyski. fixes #9112 #9111

comment:3   nbachiyski — 3 years ago

  • Status changed from closed to reopened
  • Resolution fixed deleted

Here is an updated version of the patch, which replaces all __ngettext versions with _n. The previous didn't apply cleanly.

nbachiyski — 3 years ago

comment:4   ryan — 3 years ago

  • Status changed from reopened to closed
  • Resolution set to fixed

[10606]

comment:5   ryan — 3 years ago

(In [10606]) Use _n(). Props nbachiyski. fixes #9111

Note: See TracTickets for help on using tickets.