Opened 4 years ago
Closed 4 years ago
#9193 closed defect (bug) (fixed)
get_terms() in wp_tag_cloud() didn't return a int
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | low | Milestone: | 2.8 |
| Component: | Taxonomy | Version: | 2.7 |
| Severity: | normal | Keywords: | has-patch taxonomy get_term_link wp_tag_cloud |
| Cc: |
Description
I took me a while, and I hope my analyse is correct. I try to use wp_tag_cloud() for my own taxonomy, but I'm not able to get a vaild term link. In get_term_link() i found that it look for a int|string|object. The term->id must be a int, but get_terms() in wp_tag_cloud() return a string array, so it's not possible to get the correct link.
Attched patch change the check from is_int -> is_numeric
Attachments (2)
Change History (6)
comment:1
filosofo
— 4 years ago
I think the problem with checking is_numeric is that you're going to include searches for terms that might be numeric.
Better to address the problem at the source and pass an integer to get_term_link, when that's what you want. My patch should do that; does it solve your problem?
is_numeric instead is_int