Opened 4 years ago

Last modified 2 years ago

#9306 new enhancement

Additional smart quote suggestion

Reported by: cloak42 Owned by:
Priority: low Milestone: Future Release
Component: Formatting Version:
Severity: trivial Keywords: close
Cc:

Description

If a user writes a post that contains a quotation inside parentheses, the open quote mark is not used. I suggest that when a quotation mark (double or single) is used after an open parenthesis, it should be a left-quote “ instead of a right quote ”. In order to be as complete as possible, it would probably be best to ensure that this is only done in the event that white space is used prior to the open parenthesis so as to prevent it printing the wrong one if, say, a sad-face smiley is used inside a quotation, like so:

She told me, "Aw, you make me a sad panda now. :("

If it's done so that it will only open the quote correctly after white space \s or a carriage return, I think that will cover the vast majority, if not all, of the situations where it would need to be used.

Change History (7)

  • Milestone changed from Unassigned to Future Release
  • Component changed from General to Formatting
  • Owner anonymous deleted
  • Keywords needs-patch added
  • Milestone changed from Future Release to 2.9
  • Milestone changed from 2.9 to Future Release

Punting due to feature freeze.

  • Keywords close added; needs-patch smart quote replacement preg_replace removed

I got this to work just by adding a space after the last quotation mark - it then renders as a proper closing quote. IMO this is quite edge and messing with how brackets are handled could break other things.

#4539 has a lot of changes to this code.

This should be reviewed when the changes there are reviewed and committed.

Note: See TracTickets for help on using tickets.