PHP notices for WordPress 2.8

[Viper007Bond]

Been catching a lot of PHP notices lately and rather than making a ton of more tickets, I figured one per milestone would be better.

So here's one for 2.8. Feel free to attach patches of your own to this ticket.

Other notice tickets: #9292 #9309 #9333 #9336 #9365 #9366 #9367 #9369 #9370 #9392 (plus more probably)

wp_explain_nonce() fix for custom nonces

(In [10857]) PHP Notice fix for non-normative nonce action strings. props Viper007Bond. see #9393

check if variable is set rather than counting it

Notice fixes for the theme installer

Don't commit 9393_theme-install.patch. It's deprecated as I didn't see #9508.

I included a fix for a notice (Undefined index: metakeyselect in admin-ajax.php) in #7541.

Notice fix for media upload. check if WP_ADMIN is defined before trying to define it.

Misc media fixes, viewing and editing an image in the image library

Update to 9393-media-fixes.diff. More notice fixes found through the media area.

Only check for unique user_nicename when updating since a user_id hasn't been created for a new user yet

(In [11052]) Notice fixes, props sivel, see #9393

Set empty file type if skipping file type check. Fixes notices when importing.

Patches still waiting:

9393-plugin-editor.diff
9393-registration.diff
9393-wp_handle_upload.diff

Deleting a widget, which is beng used generates non-existing array key notices

Sometimes the sticky option has value of 'Array'. It has been fixed, but until changing it I get the notices. Another check won't harm.

Two more tiny notice patches.

If there are no widgets don't try looping through them

Patches still waiting:

9393-plugin-editor.diff
9393-registration.diff
9393-wp_handle_upload.diff
9393-widgets.diff
9393-sticky.diff
9393-widgets-var-notice.diff

wp-admin\includes\template.php

Added patch for wp-admin\includes\template.php fixes notice for author ID function.

(In [11226]) Notice fix for plugin editor when no functions found. See #9393 props sivel.

(In [11227]) Set empty file type if skipping file type check. Fixes notices when importing. See #9393 props sivel.

(In [11229]) Fix notices when an in-use widget is deleted. See #9393 props nbachiyski

(In [11230]) Prevent notice check on invalid sticky settings. See #9393 props nbachiyski.

Todo:

• 9393-registration.diff - need to spend a little time understanding issue
• 9393-widgets-var-notice.diff - no longer applies
• template.diff - need more detail to understand issue.

Perhaps a better way to handle 9393-registration.diff is to instead of excluding ID of the user being updated created is to use the user_login.

When creating a user the users ID does not exist and is of course not in the database yet. So a notice is thrown reporting that $ID is undefined. Instead of using ID perhaps user_login would be better.

template.diff - need more detail to understand issue

The patch changes the call to the_author_ID which otherwise on current trunk produces PHP Notice: the_author_ID is deprecated since version 2.8! on the edit posts screen.

Replaces template.diff as this fixes the notice in 2 locations where as the other missed one

Apologies on the file extension for that last one. I don't know what I was thinking.

(In [11322]) Use the_author_meta(). Props sivel. see #9393

Uses get_the_author_meta instead of get_author_name()

Added patch for post_template to use get_the_author_meta ('display_name') instead of deprecated get_author_name function, fixes notice shown on publishing new posts.

(In [11331]) Use user_login instead of ID to check if user exists when creating unique nicenames. ID isn't available when inserting new users. Props sivel. see #9393

This patch replaces post_template.patch. Replaces get_author_name in all locations in which it is used

Accidental attachment of incorrect patch. Ignore the previous attachment.

This patch replaces post_template.patch. Replaces get_author_name in all locations in which it is used

(In [11370]) Migrate final get_author_name() calls to use get_the_author_meta() instead. See #9393 props sivel.

current_theme_info() is still throwing notices.

Also getting a notice while trying to add a category in edit.php (rev. 11372):

Notice: Trying to get property of non-object in /home/cristi/svn/wp/wp-includes/category-template.php on line 91

Last round of replacements for deprecated get_the_author_* and the_author_* functions.

(In [11416]) Use get_the_author_meta(). Props sivel. see #9393

A few notices on the new widgets page now -

PHP Notice: Undefined index: count in E:\webpage\svn\trunk\wp-includes\default-widgets.php on line 493 PHP Notice: Undefined index: hierarchical in E:\webpage\svn\trunk\wp-includes\default-widgets.php on line 494 PHP Notice: Undefined index: dropdown in E:\webpage\svn\trunk\wp-includes\default-widgets.php on line 495 PHP Notice: Undefined index: title in E:\webpage\svn\trunk\wp-includes\default-widgets.php on line 595 PHP Notice: Undefined index: number in E:\webpage\svn\trunk\wp-includes\default-widgets.php on line 596 PHP Notice: Undefined index: title in E:\webpage\svn\trunk\wp-includes\default-widgets.php on line 1017 PHP Notice: Undefined index: filter in E:\webpage\svn\trunk\wp-includes\default-widgets.php on line 415
No patch from me yet, sorry.

When DB Cache plugin is active, WP shows following warning many times:

Notice: Undefined index: debug in C:\wordpress28.local\wp-content\db.php on line 646

I am not sure if this is a WP or plugin issue. I am using WP 2.8 beta 2.

When DB Cache plugin is active, WP shows following warning many times:

Thats a issue in the DB Cache plugin, not WordPress.

Its probably got code such as this:

if ( $this->options['debug'] ) {
...

Which is wrong, Really, it should be written like this:

if ( isset($this->options['debug']) && $this->options['debug'] ) {
or just
if ( !empty($this->options['debug']) ) {

see #10025