Ticket #9507 (closed defect (bug): fixed)

Opened 3 years ago

Last modified 3 years ago

Unable to localize the "tag" word in the new plugin page

Reported by: mark-k Owned by: nbachiyski
Priority: normal Milestone: 2.8
Component: I18N Version: 2.7.1
Severity: normal Keywords: has-patch
Cc:

Description

in plugin-install.php the tag word is localized using _e('Tag'). this seems to conflict with a different localization of 'Tag' done by using ngettext( 'Tag', 'Tags', $num_tags ), and the first version is not translated at all.

I guess that the simplest solution will be to change it to _e('Tag|plugin').

Attachments

9507.patch Download (876 bytes) - added by Viper007Bond 3 years ago.
Add "Tag" translation context
9507.2.patch Download (859 bytes) - added by Viper007Bond 3 years ago.
Use _x()

Change History

Viper007Bond — 3 years ago

Add "Tag" translation context

comment:1   Viper007Bond — 3 years ago

  • Keywords has-patch added
  • Milestone changed from Unassigned to 2.8

comment:2 follow-up: ↓ 3   ryan — 3 years ago

_c() is deprecated. Use _x().

comment:3 in reply to: ↑ 2   Viper007Bond — 3 years ago

Replying to ryan:

_c() is deprecated. Use _x().

Ah, I wondered which to use, but didn't see any mention in the phpdocs. Fresh patch incoming.

Viper007Bond — 3 years ago

Use _x()

comment:4   ryan — 3 years ago

  • Status changed from new to closed
  • Resolution set to fixed

(In [10944]) Add context to string. Props Viper007Bond. fixes #9507

Note: See TracTickets for help on using tickets.