Ticket #9514 (closed enhancement: fixed)

Opened 3 years ago

Last modified 3 years ago

Add 'page' class to the get_body_class() function

Reported by: nathanrice Owned by:
Priority: normal Milestone: 2.8
Component: Themes Version: 2.8
Severity: normal Keywords: has-patch tested
Cc: ryan

Description

Currently, there is no 'page' class assigned to the $classes array in the get_body_class() function. Consequently, there would be no way for CSS to target "all pages" with a single selector.

This is my first ticket, so I hope I did this the right way.

I've attached a diff file that adds the following code to wp-includes/post-template.php within the is_page() conditional:

if ($pageID != get_option('page_for_posts'))
	$classes[] = 'page';

I feel like this is an important addition to the classes that this function generates.

Attachments

post-template.diff Download (370 bytes) - added by nathanrice 3 years ago.
post-template.php diff file to add page class to get_body_class()

Change History

comment:1 follow-up: ↓ 2   filosofo3 years ago

I think the conditional is unnecessary; is_page() will be false when querying the page_for_posts page.

comment:2 in reply to: ↑ 1   nathanrice3 years ago

Replying to filosofo:

I think the conditional is unnecessary; is_page() will be false when querying the page_for_posts page.

Good call. I'm attaching a new diff file that just adds the 'page' class without the conditional.

post-template.php diff file to add page class to get_body_class()

  • Keywords has-patch tested added

Simple fix. Works on my end.

comment:4   ryan3 years ago

  • Status changed from new to closed
  • Resolution set to fixed

(In [10950]) Add page class to get_boddy_class(). Props nathanrice. fixes #9514

Thanks Ryan!!!

Note: See TracTickets for help on using tickets.