Ticket #9534 (closed defect (bug): duplicate)

Opened 3 years ago

Last modified 2 years ago

ș and ț characters not converted in remove_accents()

Reported by: scribu Owned by: ryan
Priority: normal Milestone:
Component: Permalinks Version:
Severity: normal Keywords: formatting has-patch
Cc: scribu@…

Description

ș and ț, which are the correct diacritic marks in Romanian, are not converted by the remove_accents() function, which leads to ugly slugs.

This patch fixes that.

Attachments

accents.patch Download (573 bytes) - added by scribu 3 years ago.
9534.diff Download (5.2 KB) - added by scribu 2 years ago.
ground work

Change History

scribu — 3 years ago

comment:1   scribu — 3 years ago

  • Cc scribu@… added

comment:2   ryan — 3 years ago

  • Owner changed from anonymous to ryan
  • Component changed from General to Permalinks

Note that we can't change the sanitizer at all until we have a means of handling slugs made with older versions of the sanitizer. Right now, sanitizer changes will cause old slugs to 404.

comment:3   scribu — 3 years ago

But aren't slugs only created once and then stored and retrieved from the db?

comment:4   ryan — 3 years ago

Incoming slugs (from permalink requests) are run through the sanitizer and they won't match the old slug.

comment:5   Denis-de-Bernardy — 3 years ago

  • Milestone changed from 2.8 to Future Release

comment:6   Denis-de-Bernardy — 3 years ago

  • Status changed from new to closed
  • Resolution set to duplicate
  • Milestone Future Release deleted

See #9591

scribu — 2 years ago

ground work

Note: See TracTickets for help on using tickets.