WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#9534 closed defect (bug) (duplicate)

ș and ț characters not converted in remove_accents()

Reported by: scribu Owned by: ryan
Priority: normal Milestone:
Component: Permalinks Version:
Severity: normal Keywords: formatting has-patch
Cc: scribu@…

Description

ș and ț, which are the correct diacritic marks in Romanian, are not converted by the remove_accents() function, which leads to ugly slugs.

This patch fixes that.

Attachments (2)

accents.patch​ (573 bytes) - added by scribu 4 years ago.
9534.diff​ (5.2 KB) - added by scribu 3 years ago.
ground work

Download all attachments as: .zip

Change History (8)

scribu — 4 years ago

comment:1 scribu — 4 years ago

  • Cc scribu@… added

comment:2 ryan — 4 years ago

  • Component changed from General to Permalinks
  • Owner changed from anonymous to ryan

Note that we can't change the sanitizer at all until we have a means of handling slugs made with older versions of the sanitizer. Right now, sanitizer changes will cause old slugs to 404.

comment:3 scribu — 4 years ago

But aren't slugs only created once and then stored and retrieved from the db?

comment:4 ryan — 4 years ago

Incoming slugs (from permalink requests) are run through the sanitizer and they won't match the old slug.

comment:5 Denis-de-Bernardy — 4 years ago

  • Milestone changed from 2.8 to Future Release

comment:6 Denis-de-Bernardy — 4 years ago

  • Milestone Future Release deleted
  • Resolution set to duplicate
  • Status changed from new to closed

See #9591

scribu — 3 years ago

ground work

Note: See TracTickets for help on using tickets.