WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#9561 closed enhancement (fixed)

plugins_dir() and plugins_basename() should also work for plugins in the MU plugins dir

Reported by: Denis-de-Bernardy Owned by:
Priority: normal Milestone: 2.8
Component: Plugins Version: 2.8
Severity: normal Keywords: has-patch tested
Cc:

Description

r10737 introduces a sweet new feature, but if a plugin in there relies on plugin_dir_url() to auto-magically get its url in order to include styles and scripts, it won't work as expected.

Attachments (2)

9561.diff​ (2.0 KB) - added by Denis-de-Bernardy 4 years ago.
missing_slash.patch​ (772 bytes) - added by alexrabe 4 years ago.

Download all attachments as: .zip

Change History (6)

Denis-de-Bernardy — 4 years ago

comment:1 DD32 — 4 years ago

+1 This looks like a good idea to me.

comment:2 azaozz — 4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [11069]) Make plugin_dir() and plugin_basename() work for mu-plugins directory, props Denis-de-Bernardy, fixes #9561

comment:3 alexrabe — 4 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Since [11069] returns plugin_basename( dirname(FILE)) a slash at the beginning. If I'm not wrong then it's missing, see attached patch

alexrabe — 4 years ago

comment:4 azaozz — 4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [11072]) Remove slash from plugin_basename(), props alexrabe, fixes #9561

Note: See TracTickets for help on using tickets.