Banishing ASCII quotes and apostrophes. Consolidated patch
|Reported by:||demetris||Owned by:|
|Severity:||normal||Keywords:||has-patch tested commit|
Please commit this before we go into string freeze for 2.8! :-)
The patch replaces all ASCII quotes (double and single) in the admin area with proper double quotes (characters 8220 and 8221), and all ASCII apostrophes with proper apostrophes (char. 8217).
I also found a few apostrophes that were typed literally (no escaping) within strings enclosed in double quotes. It seemed to me this was the only reason double quotes were used for those strings, so, in those few cases, I also changed the double quotes enclosing the strings to single quotes.
I did not change the single ASCII quotes for some JS confirm dialogs. E.g.:
'Cancel' to stop, 'OK' to proceed.
I think these single quotes are not needed at all. (My personal preference is to use quotation marks sparingly — only when absolutely necessary.)
There are also quite a few triple dots (...) that could be replaced with the ellipsis character, but I think it’s not worth disturbing strings just to put typographical ellipses in them. Triple dots seem fine to me.
PS. I would not go into the trouble of making this patch, but some instances are in prominent places, like the installer (first impression!) or in widgets descriptions.