Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#9754 closed defect (bug) (fixed)

all calls to should_defalate are passing wrong argument

Reported by: wnorris Owned by:
Priority: high Milestone: 2.8
Component: HTTP Version: 2.8
Severity: major Keywords: http has_patch
Cc: wnorris

Description

All of the calls to WP_Http_Encoding::should_decode() are passing the argument $theHeaders (or whatever that variable is named for that function. btw, why is it so inconsistent?). This array contains two keys 'headers' and 'cookies'. should_decode() is expecting only the 'headers' array, so every call to should_decode needs to be updated to pass $theHeaders['headers']. Otherwise, HTTP responses are never decompressed.

Attachments (1)

should_decode.diff​ (3.0 KB) - added by wnorris 4 years ago.

Download all attachments as: .zip

Change History (2)

wnorris — 4 years ago

comment:1   westi — 4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [11236]) Pass just the headers array to should_decode. Fixes #9754 props willnorris.

Note: See TracTickets for help on using tickets.