Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#9791 closed defect (bug) (fixed)

Use a more semantic class name for screen reader class

Reported by: filosofo Owned by:
Priority: normal Milestone: 2.8
Component: Accessibility Version: 2.8
Severity: normal Keywords: has-patch screen-reader-text
Cc: ryan

Description

To be semantic, CSS classes (and ids) should describe meaning or function, not style.

So attached patch exchanges "invisible" for "screen-reader-text".

Attachments (1)

screen_reader_text.9791.diff​ (47.6 KB) - added by filosofo 4 years ago.

Download all attachments as: .zip

Change History (5)

filosofo — 4 years ago

comment:2   markjaquith — 4 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [11312]) Use a semantic class name for text targeted to screen readers. props filosofo. fixes #9791

comment:3   nbachiyski — 4 years ago

Isn't it targeted for browsers with no/disabled JavaScript, not for text readers specifically? This class name is really long, given the number of times it is used.

comment:4   filosofo — 4 years ago

I wasn't pushing for that name in particular, just something semantic.

Note: See TracTickets for help on using tickets.