Opened 4 years ago

Last modified 3 years ago

#9927 accepted enhancement

deprecate category_description() in favor of get_category_description()

Reported by: ramiy Owned by: westi
Priority: normal Milestone: Future Release
Component: Inline Docs Version: 2.8
Severity: minor Keywords: has-patch
Cc: r_a_m_i@…

Description


Attachments (5)

9927.patch (1.4 KB) - added by ramiy 4 years ago.
9927.2.patch (1.4 KB) - added by ramiy 4 years ago.
ver.2
9927.3.patch (1.4 KB) - added by ramiy 4 years ago.
sorry, here is the latest
9927.4.patch (2.1 KB) - added by ramiy 4 years ago.
category_description() & tag_description()
9927.5.patch (3.2 KB) - added by ramiy 3 years ago.
category_description() & tag_description() & term_description()

Download all attachments as: .zip

Change History (18)

ramiy4 years ago

  • Keywords has-patch added; category removed
  • Milestone changed from 2.8 to 2.9
  • Owner set to westi
  • Status changed from new to accepted

Nice idea. Not for 2.8

if you liked this change, check #9882 too.

patch needs a slight update to change the versions, else probably good to go

How about tag_description(), which was introduced in 2.8?

ramiy4 years ago

ver.2

ramiy4 years ago

sorry, here is the latest

ramiy4 years ago

category_description() & tag_description()

  • category_description() deprecate in favor of get_category_description()
  • tag_description() deprecate in favor of get_tag_description()

The old function are still in use in deprecated.php file.

comment:7   ryan3 years ago

  • Milestone changed from 2.9 to 3.0
  • Type changed from feature request to enhancement

This is a good idea, though I'm not convinced this is worth it. If we're going to do this, we'll need to rename term_description() as well.

comment:9 follow-up: ↓ 10   ramiy3 years ago

nacin, we can rename term_description() as well.

comment:10 in reply to: ↑ 9   nacin3 years ago

Replying to ramiy:

nacin, we can rename term_description() as well.

I wasn't convinced it was worth it because that's three functions to rename, simply for get_* consistency. Surely we have other functions that don't start with "get_", especially those that also don't start with "the_", that return a value. I suppose this is considered a template tag, so I understand why we should probably do it here.

  • Component changed from Template to Inline Docs

ramiy3 years ago

category_description() & tag_description() & term_description()

  • Milestone changed from 3.0 to 3.1
  • Milestone changed from Awaiting Triage to Future Release
Note: See TracTickets for help on using tickets.