Ticket #994 (closed defect (bug): fixed)

Opened 7 years ago

Last modified 7 years ago

Installation files not internazionalized

Reported by: SteveAgl Owned by: ryan
Priority: normal Milestone:
Component: General Version: 1.5
Severity: trivial Keywords:
Cc:

Description

The files: wp-admin/install.php wp-admin/upgrade-schema.php wp-admin/wp-settings.php

have strings out of the .POT file that doesn't use gettext function.

Same for all wp-admin/import-*.php files but in this case the text is a lot and maybe it doens't worth have them full full () and _e()

Attachments

admin-i18n.diff Download (7.8 KB) - added by SteveAgl 7 years ago.
install-gettext.diff Download (4.0 KB) - added by SteveAgl 7 years ago.
install-i18n-and-email-check.diff Download (5.5 KB) - added by SteveAgl 7 years ago.

Change History

  • Patch set to No

comment:2   ryan7 years ago

  • Owner changed from anonymous to rboren
  • Status changed from new to assigned

In the patch: all above without import-* functions.

edited on: 02-27-05 21:45

comment:7   matt7 years ago

I think we should hold off on the importers for now. In 1.6 those will be integrated with the admin better and will be gettexted.

In the install.php the text at lines 188 nd 190 even if present in the .pot files, correctly impèorted into .po file and translated, are still in english. It looks like they doesn't match on gettext.

Added install-gettext.diff which gettexts the default database entries in install.php

8 strings need adding to the .pot

In the install-i18n-and-email-check.diff patch: Default post and comment texts gettexted, and e-mail validity check added to install.php. Maybe the second issue could be filed in another report, but I had to wait for the i18n patch to be applied in order to produce the e-mail check patch.

Ooops, I did not see the slebog's patch. Sorry.

The very first string in install.php is left untranslated (line 4):

die("There doesn't seem to be a <code>wp-config.php</code> file. I need this before we can get started ...

That string cannot be translated because wp-config.php must be loaded before we can make gettext calls. Since the error occurs in the event that wp-config.php cannot be loaded, gettext is not available.

  • Status changed from assigned to closed
  • fixed_in_version set to 1.5.1
  • Resolution changed from 10 to 20
Note: See TracTickets for help on using tickets.