Ticket #10441: trac-10441-change-over-existing-deprecated-hooks.6.patch

src/wp-admin/edit-form-advanced.php

@@ -278 +278 @@
  * Fires in the middle of built-in meta box registration.
  *
  * @since 2.1.0
- * @deprecated 3.7.0 Use 'add_meta_boxes' instead.
+ * @deprecated 3.7.0 Use {@see 'add_meta_boxes'} instead.
  *
  * @param WP_Post $post Post object.
  */
-do_action( 'dbx_post_advanced', $post );
+do_action_deprecated( 'dbx_post_advanced', array( $post ), '3.7.0', 'add_meta_boxes' );
 
 // Allow the Discussion meta box to show up if the post type supports comments,
 // or if comments or pings are open.

src/wp-admin/edit-tag-form.php

@@ -17 +17 @@
          * Fires before the Edit Category form.
          *
          * @since 2.1.0
-         * @deprecated 3.0.0 Use {$taxonomy}_pre_edit_form instead.
+         * @deprecated 3.0.0 Use {@see '{$taxonomy}_pre_edit_form'} instead.
          *
          * @param object $tag Current category term object.
          */
-        do_action( 'edit_category_form_pre', $tag );
+        do_action_deprecated( 'edit_category_form_pre', array( $tag ), '3.0.0', '{$taxonomy}_pre_edit_form' );
 } elseif ( 'link_category' == $taxonomy ) {
         /**
          * Fires before the Edit Link Category form.
          *
          * @since 2.3.0
-         * @deprecated 3.0.0 Use {$taxonomy}_pre_edit_form instead.
+         * @deprecated 3.0.0 Use {@see '{$taxonomy}_pre_edit_form'} instead.
          *
          * @param object $tag Current link category term object.
          */
-        do_action( 'edit_link_category_form_pre', $tag );
+        do_action_deprecated( 'edit_link_category_form_pre', array( $tag ), '3.0.0', '{$taxonomy}_pre_edit_form' );
 } else {
         /**
          * Fires before the Edit Tag form.
          *
          * @since 2.5.0
-         * @deprecated 3.0.0 Use {$taxonomy}_pre_edit_form instead.
+         * @deprecated 3.0.0 Use {@see '{$taxonomy}_pre_edit_form'} instead.
          *
          * @param object $tag Current tag term object.
          */
-        do_action( 'edit_tag_form_pre', $tag );
+        do_action_deprecated( 'edit_tag_form_pre', array( $tag ), '3.0.0', '{$taxonomy}_pre_edit_form' );
 }
 
 /**
@@ -189 +189 @@
                          * Fires after the Edit Category form fields are displayed.
                          *
                          * @since 2.9.0
-                         * @deprecated 3.0.0 Use {$taxonomy}_edit_form_fields instead.
+                         * @deprecated 3.0.0 Use {@see '{$taxonomy}_edit_form_fields'} instead.
                          *
                          * @param object $tag Current category term object.
                          */
-                        do_action( 'edit_category_form_fields', $tag );
+                        do_action_deprecated( 'edit_category_form_fields', array( $tag ), '3.0.0', '{$taxonomy}_edit_form_fields' );
                 } elseif ( 'link_category' == $taxonomy ) {
                         /**
                          * Fires after the Edit Link Category form fields are displayed.
                          *
                          * @since 2.9.0
-                         * @deprecated 3.0.0 Use {$taxonomy}_edit_form_fields instead.
+                         * @deprecated 3.0.0 Use {@see '{$taxonomy}_edit_form_fields'} instead.
                          *
                          * @param object $tag Current link category term object.
                          */
-                        do_action( 'edit_link_category_form_fields', $tag );
+                        do_action_deprecated( 'edit_link_category_form_fields', array( $tag ), '3.0.0', '{$taxonomy}_edit_form_fields' );
                 } else {
                         /**
                          * Fires after the Edit Tag form fields are displayed.
                          *
                          * @since 2.9.0
-                         * @deprecated 3.0.0 Use {$taxonomy}_edit_form_fields instead.
+                         * @deprecated 3.0.0 Use {@see '{$taxonomy}_edit_form_fields'} instead.
                          *
                          * @param object $tag Current tag term object.
                          */
-                        do_action( 'edit_tag_form_fields', $tag );
+                        do_action_deprecated( 'edit_tag_form_fields', array( $tag ), '3.0.0', '{$taxonomy}_edit_form_fields' );
                 }
                 /**
                  * Fires after the Edit Term form fields are displayed.
@@ -242 +242 @@
          * Fires at the end of the Edit Term form.
          *
          * @since 2.5.0
-         * @deprecated 3.0.0 Use {$taxonomy}_edit_form instead.
+         * @deprecated 3.0.0 Use {@see '{$taxonomy}_edit_form'} instead.
          *
          * @param object $tag Current taxonomy term object.
          */
-        do_action( 'edit_tag_form', $tag );
+        do_action_deprecated( 'edit_tag_form', array( $tag ), '3.0.0', '{$taxonomy}_edit_form' );
 }
 /**
  * Fires at the end of the Edit Term form for all taxonomies.

src/wp-admin/edit-tags.php

@@ -351 +351 @@
                  * Fires before the Add Category form.
                  *
                  * @since 2.1.0
-                 * @deprecated 3.0.0 Use {$taxonomy}_pre_add_form instead.
+                 * @deprecated 3.0.0 Use {@see '{$taxonomy}_pre_add_form'} instead.
                  *
                  * @param object $arg Optional arguments cast to an object.
                  */
-                do_action( 'add_category_form_pre', (object) array( 'parent' => 0 ) );
+                do_action_deprecated( 'add_category_form_pre', array( (object) array( 'parent' => 0 ) ), '3.0.0', '{$taxonomy}_pre_add_form' );
         } elseif ( 'link_category' == $taxonomy ) {
                 /**
                  * Fires before the link category form.
                  *
                  * @since 2.3.0
-                 * @deprecated 3.0.0 Use {$taxonomy}_pre_add_form instead.
+                 * @deprecated 3.0.0 Use {@see '{$taxonomy}_pre_add_form'} instead.
                  *
                  * @param object $arg Optional arguments cast to an object.
                  */
-                do_action( 'add_link_category_form_pre', (object) array( 'parent' => 0 ) );
+                do_action_deprecated( 'add_link_category_form_pre', array( (object) array( 'parent' => 0 ) ), '3.0.0', '{$taxonomy}_pre_add_form' );
         } else {
                 /**
                  * Fires before the Add Tag form.
                  *
                  * @since 2.5.0
-                 * @deprecated 3.0.0 Use {$taxonomy}_pre_add_form instead.
+                 * @deprecated 3.0.0 {@see '{$taxonomy}_pre_add_form'} instead.
                  *
                  * @param string $taxonomy The taxonomy slug.
                  */
-                do_action( 'add_tag_form_pre', $taxonomy );
+                do_action_deprecated( 'add_tag_form_pre', array( $taxonomy ), '3.0.0', '{$taxonomy}_pre_add_form' );
         }
 
         /**
@@ -501 +501 @@
          * Fires at the end of the Edit Category form.
          *
          * @since 2.1.0
-         * @deprecated 3.0.0 Use {$taxonomy}_add_form instead.
+         * @deprecated 3.0.0 Use {@see '{$taxonomy}_add_form'} instead.
          *
          * @param object $arg Optional arguments cast to an object.
          */
-        do_action( 'edit_category_form', (object) array( 'parent' => 0 ) );
+        do_action_deprecated( 'edit_category_form', array( (object) array( 'parent' => 0 ) ), '3.0.0', '{$taxonomy}_add_form' );
 } elseif ( 'link_category' == $taxonomy ) {
         /**
          * Fires at the end of the Edit Link form.
          *
          * @since 2.3.0
-         * @deprecated 3.0.0 Use {$taxonomy}_add_form instead.
+         * @deprecated 3.0.0 Use {@see '{$taxonomy}_add_form'} instead.
          *
          * @param object $arg Optional arguments cast to an object.
          */
-        do_action( 'edit_link_category_form', (object) array( 'parent' => 0 ) );
+        do_action_deprecated( 'edit_link_category_form', array( (object) array( 'parent' => 0 ) ), '3.0.0', '{$taxonomy}_add_form' );
 } else {
         /**
          * Fires at the end of the Add Tag form.
          *
          * @since 2.7.0
-         * @deprecated 3.0.0 Use {$taxonomy}_add_form instead.
+         * @deprecated 3.0.0 Use {@see '{$taxonomy}_add_form'} instead.
          *
          * @param string $taxonomy The taxonomy slug.
          */
-        do_action( 'add_tag_form', $taxonomy );
+        do_action_deprecated( 'add_tag_form', array( $taxonomy ), '3.0.0', '{$taxonomy}_add_form' );
 }
 
 /**

src/wp-admin/includes/class-wp-screen.php

@@ -732 +732 @@
                  * Filters the legacy contextual help list.
                  *
                  * @since 2.7.0
-                 * @deprecated 3.3.0 Use get_current_screen()->add_help_tab() or
-                 *                   get_current_screen()->remove_help_tab() instead.
+                 * @deprecated 3.3.0 Use {@see get_current_screen()->add_help_tab()} or
+                 *                   {@see get_current_screen()->remove_help_tab()} instead.
                  *
                  * @param array     $old_compat_help Old contextual help.
                  * @param WP_Screen $this            Current WP_Screen instance.
                  */
-                self::$_old_compat_help = apply_filters( 'contextual_help_list', self::$_old_compat_help, $this );
+                self::$_old_compat_help = apply_filters_deprecated( 'contextual_help_list', array( self::$_old_compat_help, $this ), '3.3.0', false, __( 'Use get_current_screen()->add_help_tab() or get_current_screen()->remove_help_tab() instead.' ) );
 
                 $old_help = isset( self::$_old_compat_help[ $this->id ] ) ? self::$_old_compat_help[ $this->id ] : '';
 
@@ -746 +746 @@
                  * Filters the legacy contextual help text.
                  *
                  * @since 2.7.0
-                 * @deprecated 3.3.0 Use get_current_screen()->add_help_tab() or
-                 *                   get_current_screen()->remove_help_tab() instead.
+                 * @deprecated 3.3.0 Use {@see get_current_screen()->add_help_tab()} or
+                 *                   {@see get_current_screen()->remove_help_tab()} instead.
                  *
                  * @param string    $old_help  Help text that appears on the screen.
                  * @param string    $screen_id Screen ID.
                  * @param WP_Screen $this      Current WP_Screen instance.
                  *
                  */
-                $old_help = apply_filters( 'contextual_help', $old_help, $this->id, $this );
+                $old_help = apply_filters_deprecated( 'contextual_help', array( $old_help, $this->id, $this ), '3.3.0', false, __( 'Use get_current_screen()->add_help_tab() or get_current_screen()->remove_help_tab() instead.' ) );
 
                 // Default help only if there is no old-style block of text and no new-style help tabs.
                 if ( empty( $old_help ) && ! $this->get_help_tabs() ) {
@@ -763 +763 @@
                          * Filters the default legacy contextual help text.
                          *
                          * @since 2.8.0
-                         * @deprecated 3.3.0 Use get_current_screen()->add_help_tab() or
-                         *                   get_current_screen()->remove_help_tab() instead.
+                         * @deprecated 3.3.0 Use {@see get_current_screen()->add_help_tab()} or
+                         *                   {@see get_current_screen()->remove_help_tab()} instead.
                          *
                          * @param string $old_help_default Default contextual help text.
                          */
-                        $default_help = apply_filters( 'default_contextual_help', '' );
+                        $default_help = apply_filters_deprecated( 'default_contextual_help', array( '' ), '3.3.0', false, __( 'Use get_current_screen()->add_help_tab() or get_current_screen()->remove_help_tab() instead.' ) );
                         if ( $default_help )
                                 $old_help = '<p>' . $default_help . '</p>';
                 }

src/wp-admin/includes/class-wp-terms-list-table.php

@@ -91 +91 @@
                          * Filters the number of terms displayed per page for the Tags list table.
                          *
                          * @since 2.7.0
-                         * @deprecated 2.8.0 Use edit_tags_per_page instead.
+                         * @deprecated 2.8.0 Use {@see 'edit_tags_per_page'} instead.
                          *
                          * @param int $tags_per_page Number of tags to be displayed. Default 20.
                          */
-                        $tags_per_page = apply_filters( 'tagsperpage', $tags_per_page );
+                        $tags_per_page = apply_filters_deprecated( 'tagsperpage', array( $tags_per_page ), '2.8.0', 'edit_tags_per_page' );
                 } elseif ( 'category' === $this->screen->taxonomy ) {
                         /**
                          * Filters the number of terms displayed per page for the Categories list table.
@@ -472 +472 @@
                  * Filters the action links displayed for each term in the Tags list table.
                  *
                  * @since 2.8.0
-                 * @deprecated 3.0.0 Use {$taxonomy}_row_actions instead.
+                 * @deprecated 3.0.0 Use {@see '{$taxonomy}_row_actions'} instead.
                  *
                  * @param array  $actions An array of action links to be displayed. Default
                  *                        'Edit', 'Quick Edit', 'Delete', and 'View'.
                  * @param object $tag     Term object.
                  */
-                $actions = apply_filters( 'tag_row_actions', $actions, $tag );
+                $actions = apply_filters_deprecated( 'tag_row_actions', array( $actions, $tag ), '3.0.0', '{$taxonomy}_row_actions' );
 
                 /**
                  * Filters the action links displayed for each term in the terms list table.

src/wp-admin/includes/image-edit.php

@@ -262 +262 @@
                  * Filters the GD image resource to be streamed to the browser.
                  *
                  * @since 2.9.0
-                 * @deprecated 3.5.0 Use image_editor_save_pre instead.
+                 * @deprecated 3.5.0 Use {@see 'image_editor_save_pre'} instead.
                  *
                  * @param resource $image   Image resource to be streamed.
                  * @param int      $post_id Post ID.
                  */
-                $image = apply_filters( 'image_save_pre', $image, $post_id );
+                $image = apply_filters_deprecated( 'image_save_pre', array( $image, $post_id ), '3.5.0', 'image_editor_save_pre' );
 
                 switch ( $mime_type ) {
                         case 'image/jpeg':
@@ -333 +333 @@
                  * returning that value instead.
                  *
                  * @since 2.9.0
-                 * @deprecated 3.5.0 Use wp_save_image_editor_file instead.
+                 * @deprecated 3.5.0 Use {@see 'wp_save_image_editor_file'} instead.
                  *
                  * @param mixed           $override  Value to return instead of saving. Default null.
                  * @param string          $filename  Name of the file to be saved.
@@ -341 +341 @@
                  * @param string          $mime_type Image mime type.
                  * @param int             $post_id   Post ID.
                  */
-                $saved = apply_filters( 'wp_save_image_file', null, $filename, $image, $mime_type, $post_id );
+                $saved = apply_filters_deprecated( 'wp_save_image_file', array( null, $filename, $image, $mime_type, $post_id ), '3.5.0', 'wp_save_image_editor_file' );
 
                 if ( null !== $saved )
                         return $saved;
@@ -528 +528 @@
                  * Filters the GD image resource before applying changes to the image.
                  *
                  * @since 2.9.0
-                 * @deprecated 3.5.0 Use wp_image_editor_before_change instead.
+                 * @deprecated 3.5.0 Use {@see 'wp_image_editor_before_change'} instead.
                  *
                  * @param resource $image   GD image resource.
                  * @param array    $changes Array of change operations.
                  */
-                $image = apply_filters( 'image_edit_before_change', $image, $changes );
+                $image = apply_filters_deprecated( 'image_edit_before_change', array( $image, $changes ), '3.5.0', 'wp_image_editor_before_change' );
         }
 
         foreach ( $changes as $operation ) {

src/wp-admin/includes/media.php

@@ -577 +577 @@
          *
          * @param string $string Media buttons context. Default empty.
          */
-        $legacy_filter = apply_filters( 'media_buttons_context', '' );
+        $legacy_filter = apply_filters_deprecated( 'media_buttons_context', array( '' ), '3.5.0', false, __( 'Use \'media_buttons\' action instead.' ) );
 
         if ( $legacy_filter ) {
                 // #WP22559. Close <a> if a plugin started by closing <a> to open their own <a> tag.

src/wp-includes/class-wp-rewrite.php

@@ -1420 +1420 @@
                                  * Filters rewrite rules used specifically for Tags.
                                  *
                                  * @since 2.3.0
-                                 * @deprecated 3.1.0 Use 'post_tag_rewrite_rules' instead
+                                 * @deprecated 3.1.0 Use {@see 'post_tag_rewrite_rules'} instead
                                  *
                                  * @param array $rules The rewrite rules generated for tags.
                                  */
-                                $rules = apply_filters( 'tag_rewrite_rules', $rules );
+                                $rules = apply_filters_deprecated( 'tag_rewrite_rules', array( $rules ), '3.1.0', 'post_tag_rewrite_rules' );
                         }
 
                         $this->extra_rules_top = array_merge($this->extra_rules_top, $rules);
@@ -1562 +1562 @@
                  * Filters the list of rewrite rules formatted for output to an .htaccess file.
                  *
                  * @since 1.5.0
-                 * @deprecated 1.5.0 Use the mod_rewrite_rules filter instead.
+                 * @deprecated 1.5.0 Use the {@see 'mod_rewrite_rules'} filter instead.
                  *
                  * @param string $rules mod_rewrite Rewrite rules formatted for .htaccess.
                  */
-                return apply_filters( 'rewrite_rules', $rules );
+                return apply_filters_deprecated( 'rewrite_rules', array( $rules ), '1.5.0', 'mod_rewrite_rules' );
         }
 
         /**

src/wp-includes/class-wp.php

@@ -535 +535 @@
                          * Filters the query string before parsing.
                          *
                          * @since 1.5.0
-                         * @deprecated 2.1.0 Use 'query_vars' or 'request' filters instead.
+                         * @deprecated 2.1.0 Use {@see 'query_vars'} or {@see 'request'} filters instead.
                          *
                          * @param string $query_string The query string to modify.
                          */
-                        $this->query_string = apply_filters( 'query_string', $this->query_string );
+                        $this->query_string = apply_filters_deprecated( 'query_string', array( $this->query_string ), '2.1.0', false, __( 'Use \'query_vars\' or \'request\' filters instead.' ) );
                         parse_str($this->query_string, $this->query_vars);
                 }
         }

src/wp-includes/deprecated.php

@@ -3553 +3553 @@
                  *
                  * @param string $output Text for the rich text editor.
                  */
-                return apply_filters( 'richedit_pre', '' );
+                return apply_filters_deprecated( 'richedit_pre', array( '' ), '4.3.0' );
         }
 
         $output = convert_chars($text);
@@ -3591 +3591 @@
          *
          * @param string $output The HTML-formatted text.
          */
-        return apply_filters( 'htmledit_pre', $output );
+        return apply_filters_deprecated( 'htmledit_pre', array( $output ), '4.3.0' );
 }
 
 /**

src/wp-includes/post.php

@@ -5331 +5331 @@
                  *
                  * @param string $cap Capability.
                  */
-                if ( ! $cap = apply_filters( 'pub_priv_sql_capability', '' ) ) {
+                if ( ! $cap = apply_filters_deprecated( 'pub_priv_sql_capability', array( '' ), '3.2.0', false, __( 'The hook transitioned from "somewhat useless" to "totally useless".' ) ) ) {
                         $cap = current_user_can( $post_type_obj->cap->read_private_posts );
                 }
 
@@ -5720 +5720 @@
                  * Fires when a post's status is transitioned from private to published.
                  *
                  * @since 1.5.0
-                 * @deprecated 2.3.0 Use 'private_to_publish' instead.
+                 * @deprecated 2.3.0 Use {@see 'private_to_publish'} instead.
                  *
                  * @param int $post_id Post ID.
                  */
-                do_action('private_to_published', $post->ID);
+                do_action_deprecated( 'private_to_published', array( $post->ID ), '2.3.0', 'private_to_publish' );
         }
 
         // If published posts changed clear the lastpostmodified cache.

src/wp-includes/rss.php

@@ -24 +24 @@
  * @since 2.3.0
  * @deprecated 3.0.0
  */
-do_action( 'load_feed_engine' );
+do_action_deprecated( 'load_feed_engine', array(), '3.0.0' );
 
 /** RSS feed constant. */
 define('RSS', 'RSS');

src/wp-includes/taxonomy.php

@@ -4109 +4109 @@
                  * Filters the tag link.
                  *
                  * @since 2.3.0
-                 * @deprecated 2.5.0 Use 'term_link' instead.
+                 * @deprecated 2.5.0 Use {@see 'term_link'} instead.
                  *
                  * @param string $termlink Tag link URL.
                  * @param int    $term_id  Term ID.
                  */
-                $termlink = apply_filters( 'tag_link', $termlink, $term->term_id );
+                $termlink = apply_filters_deprecated( 'tag_link', array( $termlink, $term->term_id ), '2.5.0', 'term_link' );
         } elseif ( 'category' == $taxonomy ) {
 
                 /**
                  * Filters the category link.
                  *
                  * @since 1.5.0
-                 * @deprecated 2.5.0 Use 'term_link' instead.
+                 * @deprecated 2.5.0 Use {@see 'term_link'} instead.
                  *
                  * @param string $termlink Category link URL.
                  * @param int    $term_id  Term ID.
                  */
-                $termlink = apply_filters( 'category_link', $termlink, $term->term_id );
+                $termlink = apply_filters_deprecated( 'category_link', array( $termlink, $term->term_id ), '2.5.0', 'term_link' );
         }
 
         /**

src/wp-includes/user.php

@@ -2044 +2044 @@
          * Use the {@see 'retrieve_password'} hook instead.
          *
          * @since 1.5.0
-         * @deprecated 1.5.1 Misspelled. Use 'retrieve_password' hook instead.
+         * @deprecated 1.5.1 Misspelled. Use {@see 'retrieve_password'} hook instead.
          *
          * @param string $user_login The user login name.
          */
-        do_action( 'retreive_password', $user->user_login );
+        do_action_deprecated( 'retreive_password', array( $user->user_login ), '1.5.1', 'retrieve_password' );
 
         /**
          * Fires before a new password is retrieved.

src/wp-signup.php

@@ -406 +406 @@
          *
          * @param array $blog_meta_defaults An array of default blog meta variables.
          */
-        $meta_defaults = apply_filters( 'signup_create_blog_meta', $blog_meta_defaults );
+        $meta_defaults = apply_filters_deprecated( 'signup_create_blog_meta', array( $blog_meta_defaults ), '3.0.0', 'add_signup_meta' );
 
         /**
          * Filters the new default site meta variables.