Ticket #11683: 11683.2.diff

src/wp-includes/meta.php

@@ -194 +194 @@
                 }
         }
 
-        if ( ! $meta_id = $wpdb->get_var( $wpdb->prepare( "SELECT $id_column FROM $table WHERE meta_key = %s AND $column = %d", $meta_key, $object_id ) ) )
+        $meta_ids = $wpdb->get_col( $wpdb->prepare( "SELECT $id_column FROM $table WHERE meta_key = %s AND $column = %d", $meta_key, $object_id ) );
+        if ( empty( $meta_ids ) ) {
                 return add_metadata($meta_type, $object_id, $meta_key, $passed_value);
+        }
 
         $_meta_value = $meta_value;
         $meta_value = maybe_serialize( $meta_value );
@@ -221 +223 @@
          * @param string $meta_key   Meta key.
          * @param mixed  $meta_value Meta value.
          */
-        do_action( "update_{$meta_type}_meta", $meta_id, $object_id, $meta_key, $_meta_value );
+        foreach ( $meta_ids as $meta_id ) {
+                do_action( "update_{$meta_type}_meta", $meta_id, $object_id, $meta_key, $_meta_value );
+        }
 
-        if ( 'post' == $meta_type )
+        if ( 'post' == $meta_type ) {
                 /**
                  * Fires immediately before updating a post's metadata.
                  *
@@ -234 +238 @@
                  * @param string $meta_key   Meta key.
                  * @param mixed  $meta_value Meta value.
                  */
-                do_action( 'update_postmeta', $meta_id, $object_id, $meta_key, $meta_value );
+                foreach ( $meta_ids as $meta_id ) {
+                        do_action( 'update_postmeta', $meta_id, $object_id, $meta_key, $meta_value );
+                }
+        }
 
         $result = $wpdb->update( $table, $data, $where );
         if ( ! $result )
@@ -255 +262 @@
          * @param string $meta_key   Meta key.
          * @param mixed  $meta_value Meta value.
          */
-        do_action( "updated_{$meta_type}_meta", $meta_id, $object_id, $meta_key, $_meta_value );
+        foreach ( $meta_ids as $meta_id ) {
+                do_action( "updated_{$meta_type}_meta", $meta_id, $object_id, $meta_key, $_meta_value );
+        }
 
         if ( 'post' == $meta_type ) {
                 /**
@@ -268 +277 @@
                  * @param string $meta_key   Meta key.
                  * @param mixed  $meta_value Meta value.
                  */
-                do_action( 'updated_postmeta', $meta_id, $object_id, $meta_key, $meta_value );
+                foreach ( $meta_ids as $meta_id ) {
+                        do_action( 'updated_postmeta', $meta_id, $object_id, $meta_key, $meta_value );
+                }
         }
 
         return true;

tests/phpunit/tests/meta.php

@@ -4 +4 @@
  * @group meta
  */
 class Tests_Meta extends WP_UnitTestCase {
+        protected $updated_mids = array();
+
         function setUp() {
                 parent::setUp();
                 $this->author = new WP_User( $this->factory->user->create( array( 'role' => 'author' ) ) );
@@ -76 +78 @@
                 $this->assertFalse( $first === $second );
         }
 
+        /**
+         * @ticket 11683
+         */
+        public function test_update_metadata_hooks_for_multiple_updated_rows() {
+                add_metadata( 'post', 1, 'test_key', 'value_1' );
+                add_metadata( 'post', 1, 'test_key', 'value_2' );
+                add_action( 'update_post_meta', array( $this, 'updated_meta' ) );
+                add_action( 'update_postmeta', array( $this, 'updated_meta' ) );
+                add_action( 'updated_post_meta', array( $this, 'updated_meta' ) );
+                add_action( 'updated_postmeta', array( $this, 'updated_meta' ) );
+
+                update_metadata( 'post', 1, 'test_key', 'value_3' );
+
+                remove_action( 'update_post_meta', array( $this, 'updated_meta' ) );
+                remove_action( 'update_postmeta', array( $this, 'updated_meta' ) );
+                remove_action( 'updated_post_meta', array( $this, 'updated_meta' ) );
+                remove_action( 'updated_postmeta', array( $this, 'updated_meta' ) );
+
+                $found = $this->updated_mids;
+                $this->updated_mids = array();
+
+                foreach ( $found as $action => $mids ) {
+                        $this->assertSame( 2, count( $mids ) );
+                }
+        }
+
         function test_metadata_exists() {
                 $this->assertFalse( metadata_exists( 'user',  $this->author->ID, 'foobarbaz' ) );
                 $this->assertTrue( metadata_exists( 'user',  $this->author->ID, 'meta_key' ) );
@@ -263 +291 @@
                 $this->assertFalse( update_metadata_by_mid( 'user', array( 1 ), 'meta_new_value' ) );
                 $this->assertFalse( delete_metadata_by_mid( 'user', array( 1 ) ) );
         }
+
+        /** Helpers **********************************************************/
+
+        public function updated_meta( $meta_id ) {
+                $this->updated_mids[ current_action() ][] = $meta_id;
+        }
 }