Ticket #12372: remove_archaic_reference_returns.12372.diff

wp-includes/post.php

@@ -240 +240 @@
  * @param string $output Optional. Constant for return type, either OBJECT (default), ARRAY_A, ARRAY_N.
  * @return array|bool False on failure and the type will be determined by $output parameter.
  */
-function &get_children($args = '', $output = OBJECT) {
+function get_children($args = '', $output = OBJECT) {
         $kids = array();
         if ( empty( $args ) ) {
                 if ( isset( $GLOBALS['post'] ) ) {
@@ -269 +269 @@
         update_post_cache($children);
 
         foreach ( $children as $key => $child )
-                $kids[$child->ID] =& $children[$key];
+                $kids[$child->ID] = $children[$key];
 
         if ( $output == OBJECT ) {
                 return $kids;

wp-content/themes/twentyten/loop.php

@@ -30 +30 @@
                 <div class="entry-content">
                         <div class="gallery-thumb">
                                 <a class="size-thumbnail" href="<?php the_permalink(); ?>"><?php
-                                $images =& get_children( array('post_parent' => $post->ID, 'post_type' => 'attachment', 'post_mime_type' => 'image', 'orderby' => 'menu_order', 'order' => 'ASC', 'numberposts' => 999) );
+                                $images = get_children( array('post_parent' => $post->ID, 'post_type' => 'attachment', 'post_mime_type' => 'image', 'orderby' => 'menu_order', 'order' => 'ASC', 'numberposts' => 999) );
                                 $total_images = count($images);
                                 $image = array_shift($images);
                                 echo wp_get_attachment_image( $image->ID, 'thumbnail' );
@@ -124 +124 @@
                                         <div class="nav-previous"><?php next_posts_link(__( '<span class="meta-nav">&larr;</span> Older posts', 'twentyten' )); ?></div>
                                         <div class="nav-next"><?php previous_posts_link(__( 'Newer posts <span class="meta-nav">&rarr;</span>', 'twentyten' )); ?></div>
                                 </div><!-- #nav-below -->
-<?php } ?>
- No newline at end of file
+<?php } ?>