Ticket #12386: ms_confirm_delete.diff

includes/ms.php

@@ -166 +166 @@
 function confirm_delete_users( $users ) {
         if ( !is_array( $users ) )
                 return false;
-
-        echo '<p>' . __( 'Transfer posts before deleting users:' ) . '</p>';
-
-        echo '<form action="ms-edit.php?action=allusers" method="post">';
-        echo '<input type="hidden" name="alluser_transfer_delete" />';
+        
+    screen_icon('tools');
+    ?>
+        <h2><?php esc_html_e('Users'); ?></h2>
+        <p><?php _e( 'Transfer posts before deleting users:' ); ?></p>
+        <form action="ms-edit.php?action=allusers" method="post">
+        <input type="hidden" name="alluser_transfer_delete" />
+    <?php
         wp_nonce_field( 'allusers' );
         foreach ( (array) $_POST['allusers'] as $key => $val ) {
                 if ( $val != '' && $val != '0' ) {
+            $allusers[] = $val;
                         $user = new WP_User( $val );
+            
                         if ( in_array( $user->user_login, get_site_option( 'site_admins', array( 'admin' ) ) ) )
                                 wp_die( sprintf( __( 'Warning! User cannot be deleted. The user %s is a site admnistrator.' ), $user->user_login ) );
+                
                         echo "<input type='hidden' name='user[]' value='{$val}'/>\n";
                         $blogs = get_blogs_of_user( $val, true );
+            
                         if ( !empty( $blogs ) ) {
                                 foreach ( (array) $blogs as $key => $details ) {
                                         $blog_users = get_users_of_blog( $details->userblog_id );
@@ -187 +194 @@
                                                 echo "<select name='blog[$val][{$key}]'>";
                                                 $out = '';
                                                 foreach ( $blog_users as $user ) {
-                                                        if ( $user->user_id != $val )
+                                                        if ( $user->user_id != $val && !in_array( $val, $allusers ) )
                                                                 $out .= "<option value='{$user->user_id}'>{$user->user_login}</option>";
                                                 }
                                                 if ( $out == '' )
-                                                        $out = "<option value='1'>admin</option>";
+                                                        $out = '<option value="1">admin</option>'; // todo: change, because admin is fix
                                                 echo $out;
                                                 echo "</select>\n";
                                         }
@@ -199 +206 @@
                         }
                 }
         }
-        echo "<br /><input type='submit' value='" . __( 'Delete user and transfer posts' ) . "' />";
-        echo "</form>";
+        ?>
+    <br class="clear" />
+    <input type="submit" class="button-secondary delete" value="<?php _e( 'Delete user and transfer posts' ); ?> " />
+        </form>
+    <?php
         return true;
 }
 

ms-edit.php

@@ -465 +465 @@
                         echo '<div class="wrap" style="position:relative;">';
                         confirm_delete_users( $_POST['allusers'] );
                         echo '</div>';
+            require_once('admin-footer.php');
                 } elseif ( isset( $_POST[ 'alluser_transfer_delete' ] ) ) {
                         if ( is_array( $_POST[ 'blog' ] ) && !empty( $_POST[ 'blog' ] ) ) {
                                 foreach ( $_POST[ 'blog' ] as $id => $users ) {