Ticket #12494: 12494.patch

wp-includes/post-template.php

@@ -950 +950 @@
                 'selected' => 0, 'echo' => 1,
                 'name' => 'page_id', 'id' => '',
                 'show_option_none' => '', 'show_option_no_change' => '',
-                'option_none_value' => ''
+                'option_none_value' => '',
+                'optio_value_field' => 'id'
         );
 
         $r = wp_parse_args( $args, $defaults );
@@ -1412 +1413 @@
         public function start_el( &$output, $page, $depth = 0, $args = array(), $id = 0 ) {
                 $pad = str_repeat(' ', $depth * 3);
 
-                $output .= "\t<option class=\"level-$depth\" value=\"$page->ID\"";
-                if ( $page->ID == $args['selected'] )
+                if ( 'slug' == $args['option_value_field'] ) {
+                        $value = $page->post_name;
+                        $selected = $page->post_name == $args['selected'];
+                } else {
+                        $value = $page->ID;
+                        $selected = $page->ID == $args['selected'];
+                }
+
+                $output .= "\t<option class=\"level-$depth\" value=\"$value\"";
+                if ( $selected )
                         $output .= ' selected="selected"';
                 $output .= '>';
 

wp-includes/category-template.php

@@ -291 +291 @@
  *     'show_option_all' (string) - Text to display for showing all categories.
  *     'show_option_none' (string) - Text to display for showing no categories.
  *     'option_none_value' (mixed) - Value to use when no category is selected.
+ *     'option_value_field' (string) - What column to use for the option value
+ * attribute. Can either be 'slug' or 'id'. Defaults to 'id'.
  *     'orderby' (string) default is 'ID' - What column to use for ordering the
  * categories.
  *     'order' (string) default is 'ASC' - What direction to order categories.
@@ -330 +332 @@
                 'name' => 'cat', 'id' => '',
                 'class' => 'postform', 'depth' => 0,
                 'tab_index' => 0, 'taxonomy' => 'category',
-                'hide_if_empty' => false, 'option_none_value' => -1
+                'hide_if_empty' => false, 'option_none_value' => -1,
+                'option_value_field' => 'id'
         );
 
         $defaults['selected'] = ( is_category() ) ? get_query_var( 'cat' ) : 0;
@@ -1098 +1101 @@
                 /** This filter is documented in wp-includes/category-template.php */
                 $cat_name = apply_filters( 'list_cats', $category->name, $category );
 
-                $output .= "\t<option class=\"level-$depth\" value=\"".$category->term_id."\"";
-                if ( $category->term_id == $args['selected'] )
+                if ( 'slug' == $args['option_value_field'] ) {
+                        $value = $category->slug;
+                        $selected = $category->slug == $args['selected'];
+                } else {
+                        $value = $category->term_id;
+                        $selected = $category->term_id == $args['selected'];
+                }
+
+                $output .= "\t<option class=\"level-$depth\" value=\"$value\"";
+                if ( $selected )
                         $output .= ' selected="selected"';
                 $output .= '>';
                 $output .= $pad.$cat_name;