Ticket #13198: twentyten_printf_fixes.patch

wp-content/themes/twentyten/attachment.php

@@ -22 +22 @@
 
                                         <div class="entry-meta">
                                                 <?php
-                                                        printf(__( '<span class="meta-prep meta-prep-author"> By </span> <span class="author vcard"><a class="url fn n" href="%1$s" title="%2$s">%3$s</a></span>', 'twentyten'),
+                                                        printf(__( '<span class="meta-prep meta-prep-author">By </span> <span class="author vcard"><a class="url fn n" href="%1$s" title="%2$s">%3$s</a></span>', 'twentyten'),
                                                                 get_author_posts_url( get_the_author_meta( 'ID' ) ),
                                                                 sprintf( esc_attr__( 'View all posts by %s', 'twentyten' ), get_the_author() ),
                                                                 get_the_author()

wp-content/themes/twentyten/footer.php

@@ -24 +24 @@
 
                         <div id="site-generator">
                                 <?php do_action('twentyten_credits' ); ?>
-                                <a href="http://wordpress.org/" title="<?php esc_attr_e( 'Semantic Personal Publishing Platform', 'twentyten' ); ?>" rel="generator"><?php printf( __( 'Proudly powered by %s.', 'twentyten' ), 'WordPress' ); ?></a>
+                                <?php _e( '<a href="http://wordpress.org/" title="Semantic Personal Publishing Platform" rel="generator">Proudly powered by WordPress.</a>' , 'twentyten' ); ?>
                         </div>
 
                 </div><!-- #colophon -->

wp-content/themes/twentyten/single.php

@@ -24 +24 @@
                                         <h1 class="entry-title"><?php the_title(); ?></h1>
 
                                         <div class="entry-meta">
-                                                <span class="meta-prep meta-prep-author"><?php _e( 'Posted on ', 'twentyten' ); ?></span>
-                                                <a href="<?php the_permalink(); ?>" title="<?php the_time(); ?>" rel="bookmark"><span class="entry-date"><?php echo get_the_date(); ?></span></a>
-                                                <span class="meta-sep"><?php _e( ' by ', 'twentyten' ); ?></span>
-                                                <span class="author vcard"><a class="url fn n" href="<?php echo get_author_posts_url( get_the_author_meta( 'ID' ) ); ?>" title="<?php printf( esc_attr__( 'View all posts by %s', 'twentyten' ), get_the_author() ); ?>"><?php the_author(); ?></a></span>
+                                                <?php
+                                                        printf( __( '<span class="meta-prep meta-prep-author">Posted on </span><a href="%1$s" title="%2$s" rel="bookmark"><span class="entry-date">%3$s</span></a> <span class="meta-sep"> by </span> <span class="author vcard"><a class="url fn n" href="%4$s" title="%5$s">%6$s</a></span>', 'twentyten' ),
+                                                                get_permalink(),
+                                                                esc_attr( get_the_time() ),
+                                                                get_the_date(),
+                                                                get_author_posts_url( get_the_author_meta( 'ID' ) ),
+                                                                sprintf( esc_attr__( 'View all posts by %s', 'twentyten' ), get_the_author() ),
+                                                                get_the_author()
+                                                        );
+                                                ?>
                                         </div><!-- .entry-meta -->
 
                                         <div class="entry-content">
@@ -41 +47 @@
                                                         <?php echo get_avatar( get_the_author_meta( 'user_email' ), apply_filters( 'twentyten_author_bio_avatar_size', 60 ) ); ?>
                                                 </div><!-- #author-avatar -->
                                                 <div id="author-description">
-                                                        <h2><?php _e( 'About ', 'twentyten' ); ?><?php the_author(); ?></h2>
+                                                        <h2><?php printf( esc_attr__( 'About %s', 'twentyten' ), get_the_author() ); ?></h2>
                                                         <?php the_author_meta( 'description' ); ?>
                                                         <div id="author-link">
-                                                                <a href="<?php echo get_author_posts_url( get_the_author_meta( 'ID' ) ); ?>" title="<?php printf( esc_attr__( 'View all posts by %s', 'twentyten' ), get_the_author() ); ?>"><?php _e( 'View all posts by ', 'twentyten' ); ?><?php the_author(); ?> &rarr;</a>
+                                                                <a href="<?php echo get_author_posts_url( get_the_author_meta( 'ID' ) ); ?>" title="<?php printf( esc_attr__( 'View all posts by %s', 'twentyten' ), get_the_author() ); ?>"><?php printf( esc_attr__( 'View all posts by %s &rarr;', 'twentyten' ), get_the_author() ); ?></a>
                                                         </div><!-- #author-link -->
                                                 </div><!-- #author-description -->
                                         </div><!-- .entry-author-info -->