Ticket #13220: 13220.select.all.1.patch

wp-admin/js/nav-menu.dev.js

@@ -146 +146 @@
                                 });
                         });
                 },
+                selectItem : function() {
+                        return this.each(function(){
+                                $(this).addClass('selected-menu-item')
+                                        .next().children('input').attr('checked','checked');
+                        });
+                },
+                deselectItem : function() {
+                        return this.each(function(){
+                                $(this).removeClass('selected-menu-item')
+                                        .next().children('input').removeAttr('checked');
+                        });
+                },
+                toggleItem : function() {
+                        return this.each(function(){
+                                var t = $(this);
+                                if( t.hasClass('selected-menu-item') )
+                                        t.deselectItem();
+                                else
+                                        t.selectItem();
+                        });
+                }
         });
 
         return {
@@ -309 +330 @@
                 },
                 
                 initAddMenuItemDraggables : function() {
-                        $.fn.extend({
-                                checkItem : function() {
-                                        return this.each(function(){
-                                                $(this).addClass('selected-menu-item')
-                                                        .next().children('input').attr('checked','checked');
-                                        });
-                                },
-                                uncheckItem : function() {
-                                        return this.each(function(){
-                                                $(this).removeClass('selected-menu-item')
-                                                        .next().children('input').removeAttr('checked');
-                                        });
-                                },
-                                toggleItem : function() {
-                                        return this.each(function(){
-                                                var t = $(this);
-                                                if( t.hasClass('selected-menu-item') )
-                                                        t.uncheckItem();
-                                                else
-                                                        t.checkItem();
-                                        });
-                                }
-                        });
-                        
                         var menuItems = $('.potential-menu-item');
                         menuItems.click(function(e){
                                 $(this).toggleItem();
@@ -348 +345 @@
                                                 items;
                                         
                                         // Make sure the item we're dragging is selected.
-                                        item.checkItem();
+                                        item.selectItem();
                                         // Set us to be the ajax target
                                         targetList = target.children('.menu-item-transport');
                                         // Get all checked elements and assemble selected items.
@@ -375 +372 @@
                                 stop: function(e, ui) {
                                         // Reset the targetList and unselect the menu items
                                         targetList = menuList;
-                                        menuItems.filter('.selected-menu-item').uncheckItem();
+                                        menuItems.filter('.selected-menu-item').deselectItem();
                                 }
                         });
                 },
@@ -553 +550 @@
 
                                         return false;
                                 } else if ( e.target && e.target.className && -1 != e.target.className.indexOf('select-all') ) {
-                                        var selectAreaMatch = /#(.*)$/.exec(e.target.href);
+                                        var selectAreaMatch = /#(.*)$/.exec(e.target.href), items;
                                         if ( selectAreaMatch && selectAreaMatch[1] ) {
-                                                $('#' + selectAreaMatch[1] + ' .tabs-panel-active input[type=checkbox]').attr('checked', 'checked');
+                                                items = $('#' + selectAreaMatch[1] + ' .tabs-panel-active .potential-menu-item');
+                                                if( items.length === items.filter('.selected-menu-item').length )
+                                                        items.deselectItem();
+                                                else
+                                                        items.selectItem();
                                                 return false;
                                         }
                                 }