Ticket #13822: generalize-object-change-logic.1.diff

wp-includes/nav-menu.php

@@ -780 +780 @@
 
         // give menu items draft status if their associated post objects change from "publish" to "draft", or vice versa (draft item being re-published)
         if (
-                ! empty( $post->ID ) &&
-                (
-                        ( 'publish' == $old_status && 'draft' == $new_status ) ||
-                        ( 'draft' == $old_status && 'publish' == $new_status )
-                )
+                ! empty( $post->ID ) && ! empty( $post->post_type ) &&
+                'nav_menu_item' != $post->post_type && 
+                ( 'publish' == $old_status || 'publish' == $new_status )
         ) {
                 $menu_items = get_posts(array(
                         'meta_key' => '_menu_item_object_id',
@@ -796 +794 @@
                 foreach( (array) $menu_items as $menu_item ) {
                         if ( ! empty( $menu_item->ID ) ) {
                                 $properties = get_object_vars( $menu_item );
-                                $properties['post_status'] = $new_status;
+                                $properties['post_status'] = 'publish' == $new_status ? 'publish' : 'draft';
 
                                 wp_insert_post( $properties );
                         }