Ticket #14424: 14424.diff

wp-admin/import.php

@@ -74 +74 @@
 if ( empty( $importers ) ) {
         echo '<p>' . __('No importers are available.') . '</p>'; // TODO: make more helpful
 } else {
-        uasort($importers, create_function('$a, $b', 'return strnatcasecmp($a[0], $b[0]);'));
+        uasort( $importers, '_uasort_importers_by_name' );
 ?>
 <table class="widefat importers" cellspacing="0">
 

wp-admin/includes/media.php

@@ -1992 +1992 @@
         if ( get_user_setting('uploader') )
                 $form_class .= ' html-uploader';
 
-        $_GET['paged'] = isset( $_GET['paged'] ) ? intval($_GET['paged']) : 0;
-        if ( $_GET['paged'] < 1 )
-                $_GET['paged'] = 1;
-        $start = ( $_GET['paged'] - 1 ) * 10;
-        if ( $start < 1 )
-                $start = 0;
-        add_filter( 'post_limits', create_function( '$a', "return 'LIMIT $start, 10';" ) );
+        add_filter( 'post_limits', '_media_upload_pagination_offset' );
 
         list($post_mime_types, $avail_post_mime_types) = wp_edit_attachments_query();
 
@@ -2140 +2134 @@
 }
 
 /**
+ * Returns a LIMIT clause to constrain the number of rows returned.
+ *
+ * @since 2.9.0
+ * @access private
+ *
+ * @return string The limit clause
+ */
+function _media_upload_pagination_offset() {
+        $_GET['paged'] = isset( $_GET['paged'] ) ? intval( $_GET['paged'] ) : 1;
+        $_GET['paged'] = max( $_GET['paged'], 1 );
+        $start         = absint( ( $_GET['paged'] - 1 ) * 10 );
+
+        return "LIMIT $start, 10";
+}
+
+/**
  * Creates the form for external url
  *
  * @since 2.7.0

wp-admin/includes/import.php

@@ -16 +16 @@
 function get_importers() {
         global $wp_importers;
         if ( is_array($wp_importers) )
-                uasort($wp_importers, create_function('$a, $b', 'return strcmp($a[0], $b[0]);'));
+                uasort( $wp_importers, '_uasort_importers_by_name' );
         return $wp_importers;
 }
 
 /**
+ * Sort importers by name.
+ *
+ * Used by uasort() as a callback, should not be used directly.
+ *
+ * @since 2.9.0
+ * @access private
+ *
+ * @param array $a
+ * @param array $b
+ * @return int
+ */
+function _uasort_importers_by_name( $a, $b ) {
+        return strnatcasecmp( $a[0], $b[0] );
+}
+
+/**
  * Register importer for WordPress.
  *
  * @since 2.0.0

wp-includes/category-template.php

@@ -614 +614 @@
         );
 
         if ( !isset( $args['topic_count_text_callback'] ) && isset( $args['single_text'] ) && isset( $args['multiple_text'] ) ) {
-                $body = 'return sprintf (
-                        _n(' . var_export($args['single_text'], true) . ', ' . var_export($args['multiple_text'], true) . ', $count),
-                        number_format_i18n( $count ));';
-                $args['topic_count_text_callback'] = create_function('$count', $body);
+                $args['topic_count_text_callback'] = '_plugin_topic_count';
         }
 
         $args = wp_parse_args( $args, $defaults );
@@ -717 +714 @@
         return ( $a->count > $b->count );
 }
 
+/**
+ * Default text for tooltip for tag links
+ *
+ * @since 3.9.0
+ * @access private
+ *
+ * @param integer $count Number of posts with that tag.
+ * @param object  $tag   Tag object.
+ * @param array   $args  Arguments for the tag cloud.
+ * @return string Text for the tooltip of a tag link.
+ */
+function _plugin_topic_count( $count, $tag, $args ) {
+        return sprintf( 1 == $count? $args['single_text'] : $args['multiple_text'], number_format_i18n( $count ) );
+}
+
 //
 // Helper functions
 //