Ticket #14477: 14477-41-broken-ut.2.diff

tests/phpunit/tests/post/getPages.php

@@ -272 +272 @@
         }
 
         /**
          * @ticket 14477
          */
         function test_get_pages_interrupted_hierarchy() {
                 $page1 = $this->factory->post->create( array( 'post_type' => 'page' ) );
                 $page2 = $this->factory->post->create( array( 'post_type' => 'page', 'post_parent' => $page1 ) );
                 add_post_meta( $page2, 'color', 'red' );
                 $page3 = $this->factory->post->create( array( 'post_type' => 'page', 'post_parent' => $page2 ) );
                 add_post_meta( $page3, 'color', 'blue' );
 
                 $pages = get_pages( array( 'child_of' => $page1, 'meta_key' => 'color', 'meta_value' => 'blue' ) );
                 $this->assertEqualSets( array( $page3 ), wp_list_pluck( $pages, 'ID' ) );
         }
+
+        /**
+         * @group 14477
+         */
+        function test_get_pages_broken_childs() {
+        /*
+        - A       $parent_one
+        - B       $parent_two
+         + BA     $child_one
+          + BAA   $grandchild_one
+           + BAAA $great_grandchild_one
+           + BAAB $great_grandchild_two
+         + BB     $child_two
+        */
+
+                $parent_one = $this->factory->post->create( array( 'post_type' => 'page' ) );
+                $parent_two = $this->factory->post->create( array( 'post_type' => 'page' ) );
+                        $child_one = $this->factory->post->create( array( 'post_type' => 'page', 'post_parent' => $parent_two ) );
+                                $grandchild_one = $this->factory->post->create( array( 'post_type' => 'page', 'post_parent' => $child_one ) );
+                                        $great_grandchild_one = $this->factory->post->create( array( 'post_type' => 'page', 'post_parent' => $grandchild_one ) );
+                                        $great_grandchild_two = $this->factory->post->create( array( 'post_type' => 'page', 'post_parent' => $grandchild_one ) );
+                        $child_two = $this->factory->post->create( array( 'post_type' => 'page', 'post_parent' => $parent_two ) );
+
+                $pages = get_pages( array(
+                        'child_of' => $parent_two,
+                ) );
+
+                $page_ids = wp_list_pluck( $pages, 'ID' );
+
+                // The expected structure, confirmed against 4.0
+                $expected = array(
+                        $child_one,
+                                $grandchild_one,
+                                        $great_grandchild_one,
+                                        $great_grandchild_two,
+                        $child_two
+                );
+
+                // The invalid output which 4.1 creates
+                $four_one_output = array(
+                        $child_one,
+                                $grandchild_one,
+                                        $great_grandchild_one,
+                                        $great_grandchild_two,
+
+                                $grandchild_one,
+                                        $great_grandchild_one,
+                                        $great_grandchild_two,
+
+                                        $great_grandchild_one,
+                                        $great_grandchild_two,
+                        $child_two
+                );
+
+                // Not assertEqualsSets, we want this EXACT set and order, no duplicates
+                //$this->assertEquals( $four_one_output, $page_ids );
+                $this->assertEquals( $expected, $page_ids );
+
+        }
+        
+        /**
+         * @ticket 14477
+         */
+        function test_get_page_children_order() {
+
+                $parent = $this->factory->post->create( array( 'post_type' => 'page', 'post_title' => 'BB Parent' ) );
+                        $bba = $this->factory->post->create( array( 'post_type' => 'page', 'post_title' => 'BBA Child', 'post_parent' => $parent ) );
+                        $bbb = $this->factory->post->create( array( 'post_type' => 'page', 'post_title' => 'BBB Child', 'post_parent' => $parent ) );
+                                $aaaa = $this->factory->post->create( array( 'post_type' => 'page', 'post_title' => 'AAAA Grand Child', 'post_parent' => $bbb ) );
+
+
+                $all_pages = get_pages();
+                $pages_of_child = get_page_children( $parent, $all_pages );
+
+                $expected = array(
+                        // 4.0 = Hierarchical
+                        $bba,
+                        $bbb,
+                                $aaaa
+                );
+                $four_point_one = array(
+                        // 4.1 = Alphabetical
+                        $aaaa,
+                        $bba,
+                        $bbb
+                );
+                $actual = wp_list_pluck( $pages_of_child, 'ID' );
+
+                $this->assertEquals( $expected, $actual );
+
+                // Test that wp_list_pages() + Walker gets the hierarchy correct
+                $list_pages_output = wp_list_pages( array(
+                                                                'child_of' => $parent,
+                                                                'echo' => false,
+                                                                'title_li' => ''
+                                                        ) );
+
+                // do a dance to remove all HTML and clean up the resulting whitespace mess...
+                $list_pages_output = implode( "\n", array_filter( array_map( 'rtrim', explode( "\n", strip_tags( $list_pages_output ) ) ) ) );
+                $expected = "BBA Child\n" . 
+                                        "BBB Child\n" .
+                                        "\tAAAA Grand Child";
+
+                $four_one_actual = "AAAA Grand Child\n" .
+                                                        "BBA Child\n" . 
+                                                        "BBB Child\n";
+
+                $this->assertEquals( $expected, $list_pages_output );
+
+        /*
+                The cause of this mis-match only happens when wp_list_pages() is used with the child_of parameter, and the structure presented does not have a post with a parent of 0.
+                In the event that the data doesn't have a post_parent=0 in the get_pages() result (Which it won't, as post_parent=$parent is the furthest it'll go when using child_of) then wp_list_pages() will use the first post_parent it comes accross.
+                In 4.0, as the Hierarchical order is respected, the first post_parent will be the one we're interested in, and it'll "just work"
+                In 4.1, the order is now Alphabetical, the first post_parent it finds is $bbb, which results in it displaying $aaa first, and then listing the orphans $bba and $bbb along side it.
+
+                This is ultimately a two fold issue, and can be fixed by fixing either issue
+                 - Page_Walker is hard-coded to assume the top-most parent is 0, or failing that, the first post_parent it finds
+                 - The order from get_page_children() is now different
+
+                */
+
+        }
+
 }