Ticket #16391: 16391.2.diff

wp-includes/post.php

@@ -205 +205 @@
 
         $file = apply_filters( 'update_attached_file', $file, $attachment_id );
         $file = _wp_relative_upload_path($file);
+        if ( $file )
+                return update_post_meta( $attachment_id, '_wp_attached_file', $file );
 
-        return update_post_meta( $attachment_id, '_wp_attached_file', $file );
+        return false;
 }
 
 /**
@@ -3940 +3942 @@
                 return false;
 
         $data = apply_filters( 'wp_update_attachment_metadata', $data, $post->ID );
+        if ( $data )
+                return update_post_meta( $post->ID, '_wp_attachment_metadata', $data );
 
-        return update_post_meta( $post->ID, '_wp_attachment_metadata', $data);
+        return false;
 }
 
 /**
@@ -5186 +5190 @@
         $thumbnail_id = absint( $thumbnail_id );
         if ( $post && $thumbnail_id && get_post( $thumbnail_id ) ) {
                 $thumbnail_html = wp_get_attachment_image( $thumbnail_id, 'thumbnail' );
-                if ( ! empty( $thumbnail_html ) ) {
+                if ( $thumbnail_html )
                         return update_post_meta( $post->ID, '_thumbnail_id', $thumbnail_id );
-                }
         }
         return false;
 }