Ticket #17019: 17019.5.diff

src/wp-admin/includes/class-wp-media-list-table.php

@@ -42 +42 @@
         }
 
         function get_views() {
-                global $wpdb, $post_mime_types, $avail_post_mime_types;
+                global $post_mime_types, $avail_post_mime_types;
 
                 $type_links = array();
                 $_num_posts = (array) wp_count_attachments();
                 $_total_posts = array_sum($_num_posts) - $_num_posts['trash'];
-                $total_orphans = $wpdb->get_var( "SELECT COUNT( * ) FROM $wpdb->posts WHERE post_type = 'attachment' AND post_status != 'trash' AND post_parent < 1" );
+
+                $args = array(
+                        'fields' => 'count',
+                        'post_type' => 'attachment',
+                        'post_status' => 'any',
+                        'post_parent' => 0,
+                        'suppress_filters' => false,
+                        'query_context' => 'attachment_orphans_count',
+                );
+                $total_orphans = (int) get_posts( $args );
+
                 $matches = wp_match_mime_types(array_keys($post_mime_types), array_keys($_num_posts));
                 foreach ( $matches as $type => $reals )
                         foreach ( $reals as $real )

src/wp-admin/includes/media.php

@@ -40 +40 @@
  * @return array $tabs with gallery if post has image attachment
  */
 function update_gallery_tab($tabs) {
-        global $wpdb;
-
         if ( !isset($_REQUEST['post_id']) ) {
                 unset($tabs['gallery']);
                 return $tabs;
@@ -49 +47 @@
 
         $post_id = intval($_REQUEST['post_id']);
 
-        if ( $post_id )
-                $attachments = intval( $wpdb->get_var( $wpdb->prepare( "SELECT count(*) FROM $wpdb->posts WHERE post_type = 'attachment' AND post_status != 'trash' AND post_parent = %d", $post_id ) ) );
+        if ( $post_id ) {
+                $args = array(
+                        'fields' => 'count',
+                        'post_type' => 'attachment',
+                        'post_status' => 'any',
+                        'post_parent' => $post_id,
+                        'suppress_filters' => false,
+                        'query_context' => 'gallery_attachment_count',
+                );
+                $attachments = (int) get_posts( $args );
+        }
 
         if ( empty($attachments) ) {
                 unset($tabs['gallery']);

src/wp-includes/query.php

@@ -1424 +1424 @@
                         , 'sentence'
                         , 'fields'
                         , 'menu_order'
+                        , 'query_context'
                 );
 
                 foreach ( $keys as $key ) {
@@ -2272 +2273 @@
                         case 'id=>parent':
                                 $fields = "$wpdb->posts.ID, $wpdb->posts.post_parent";
                                 break;
+                        case 'count':
+                                $fields = "COUNT(*)";
+                                break;
                         default:
                                 $fields = "$wpdb->posts.*";
                 }
@@ -2925 +2929 @@
                         return $r;
                 }
 
+                if ( 'count' == $q['fields'] ) {
+                        $this->posts = array();
+                        $this->post_count = $wpdb->get_var( $this->request );
+                        return $this->post_count;
+                }
+
                 $split_the_query = ( $old_request == $this->request && "$wpdb->posts.*" == $fields && !empty( $limits ) && $q['posts_per_page'] < 500 );
                 $split_the_query = apply_filters( 'split_the_query', $split_the_query, $this );
 

tests/phpunit/tests/query.php

@@ -78 +78 @@
                 }
 
         }
+
+        function test_fields_count() {
+                $this->factory->post->create_many( 3 );
+
+                $q = new WP_Query( array( 'fields' => 'count' ) );
+                $this->assertNotEquals( 3, $q->posts );
+                $this->assertEquals( 3, $q->post_count );
+
+                $p = get_posts( array( 'fields' => 'count' ) );
+                $this->assertEquals( 3, $p );
+        }
+
+        function test_query_context() {
+                $this->factory->post->create_many( 5 );
+
+                $q = new WP_Query( array( 'post_type' => 'post' ) );
+                $this->assertEquals( 5, $q->post_count );
+
+                add_action( 'pre_get_posts', array( $this, 'filter_pre_get_posts' ) );
+
+                $q = new WP_Query( array( 'query_context' => 'burrito' ) );
+                $this->assertEquals( 3, $q->post_count );
+
+                $q = new WP_Query( array( 'query_context' => 'taco' ) );
+                $this->assertEquals( 5, $q->post_count );
+
+                remove_action( 'pre_get_posts', array( $this, 'filter_pre_get_posts' ) );
+
+                $q = new WP_Query( array( 'query_context' => 'burrito' ) );
+                $this->assertEquals( 5, $q->post_count );
+        }
+
+        function filter_pre_get_posts( &$query ) {
+                if ( 'burrito' === $query->get( 'query_context' ) ) {
+                        $query->set( 'posts_per_page', 3 );
+                }
+        }
 }
+ No newline at end of file