Ticket #17253: 17253-2.diff

src/wp-admin/includes/schema.php

@@ -595 +595 @@
         populate_roles_270();
         populate_roles_280();
         populate_roles_300();
+        populate_roles_430();
 }
 
 /**
@@ -843 +844 @@
 }
 
 /**
+ * Create and modify WordPress roles for WordPress 4.3.
+ *
+ * @since 4.3.0
+ */
+function populate_roles_430() {
+        $role = get_role( 'author' );
+
+        if ( !empty( $role ) ) {
+                $role->add_cap( 'edit_pages' );
+                $role->add_cap( 'publish_pages' );
+                $role->add_cap( 'edit_published_pages' );
+                $role->add_cap( 'delete_pages' );
+                $role->add_cap( 'delete_published_pages' );
+        }
+}
+
+/**
  * Install Network.
  *
  * @since 3.0.0

tests/phpunit/tests/user/capabilities.php

@@ -89 +89 @@
                 $this->assertTrue($user->has_cap('upload_files'));
                 $this->assertTrue($user->has_cap('level_2'));
 
+                // extra author capabilities added in WordPress 4.3, @ticket 17253
+                $this->assertTrue( $user->has_cap( 'edit_pages' ) );
+                $this->assertTrue( $user->has_cap( 'publish_pages' ) );
+                $this->assertTrue( $user->has_cap( 'edit_published_pages' ) );
+                $this->assertTrue( $user->has_cap( 'delete_pages' ) );
+                $this->assertTrue( $user->has_cap( 'delete_published_pages' ) );
+
                 // and a few capabilities this user doesn't have
                 $this->assertFalse($user->has_cap('moderate_comments'));
                 $this->assertFalse($user->has_cap('manage_categories'));
@@ -634 +641 @@
                 $editor = new WP_User( $this->factory->user->create( array( 'role' => 'editor' ) ) );
                 $contributor = new WP_User( $this->factory->user->create( array( 'role' => 'contributor' ) ) );
 
-                // administrators, editors and the post owner can edit it
+                // administrators, editors and the page owner can edit it
                 $this->assertTrue($admin->has_cap('edit_page', $page));
                 $this->assertTrue($editor->has_cap('edit_page', $page));
+                $this->assertTrue($author->has_cap('edit_page', $page));
                 // other authors and contributors can't
-                $this->assertFalse($author->has_cap('edit_page', $page));
                 $this->assertFalse($author_2->has_cap('edit_page', $page));
                 $this->assertFalse($contributor->has_cap('edit_page', $page));
 
-                // administrators, editors and the post owner can delete it
+                // administrators, editors and the page owner can delete it
                 $this->assertTrue($admin->has_cap('delete_page', $page));
                 $this->assertTrue($editor->has_cap('delete_page', $page));
+                $this->assertTrue($editor->has_cap('delete_page', $page));
                 // other authors and contributors can't
                 $this->assertFalse($author->has_cap('delete_page', $page));
                 $this->assertFalse($author_2->has_cap('delete_page', $page));
                 $this->assertFalse($contributor->has_cap('delete_page', $page));
+
+                // administrators, editors, and authors can publish it
+                $this->assertTrue($admin->has_cap('publish_page', $page));
+                $this->assertTrue($editor->has_cap('publish_page', $page));
+                $this->assertTrue($author->has_cap('publish_page', $page));
+                $this->assertTrue($author_2->has_cap('publish_page', $page));
+                // contributors can't
+                $this->assertFalse($contributor->has_cap('publish_page', $page));
         }
 
         /**