Ticket #18412: 18412.diff

wp-includes/post.php

@@ -3913 +3913 @@
         if ( empty($url) ) //If any of the above options failed, Fallback on the GUID as used pre-2.7, not recomended to rely upon this.
                 $url = get_the_guid( $post->ID );
 
-        $url = apply_filters( 'wp_get_attachment_url', $url, $post->ID );
+        $url = apply_filters( 'wp_get_attachment_url', wp_double_encode_url($url), $post->ID );
 
         if ( 'attachment' != $post->post_type || empty( $url ) )
                 return false;
@@ -3922 +3922 @@
 }
 
 /**
+ * Double encode any accidental %XX combinations in the filename (e.g. "My%20Picture.jpg")
+ * @param string $url
+ * @return string
+ */
+function wp_double_encode_url($url) {
+        return preg_replace('/%\d\d/e', "rawurlencode(rawurlencode(urldecode('$0')))", $url);
+}
+
+/**
  * Retrieve thumbnail for an attachment.
  *
  * @since 2.1.0

wp-includes/media.php

@@ -169 +169 @@
                 // we have the actual image size, but might need to further constrain it if content_width is narrower
                 list( $width, $height ) = image_constrain_size_for_editor( $width, $height, $size );
 
-                return array( $img_url, $width, $height, $is_intermediate );
+                return array( wp_double_encode_url($img_url), $width, $height, $is_intermediate );
         }
         return false;