Ticket #18877: 18877.3.diff

src/wp-includes/class-wp-rewrite.php

@@ -1938 +1938 @@
         }
 
         /**
+         * Find a rewrite rule that matches a request.
+         *
+         * @since 4.5.0
+         * @access private
+         * @todo Explain the difference between $request and $req_uri here. Only used
+         *       for PATH_INFO links?
+         *
+         * @param string $request       The URL to match against.
+         * @param string $req_uri       The request URI.
+         * @param array  $rewrite_rules Rewrite pairs (regex matches and rewritten query strings).
+         * @return array|false $rewritten If a rule matches, an array containing
+         *                                the match and the query.
+         *                                False otherwise.
+         */
+        public function find_match( $request, $req_uri, $rewrite_rules ) {
+                $found_match = false;
+                // Look for matches.
+                $request_match = $request;
+                if ( empty( $request_match ) ) {
+                        // An empty request could only match against ^$ regex
+                        if ( isset( $rewrite_rules['$'] ) ) {
+                                $this->matched_rule = '$';
+                                $query = $rewrite_rules['$'];
+                                $matches = array('');
+                        }
+                } else {
+                        foreach ( (array) $rewrite_rules as $match => $query ) {
+                                // If the requesting file is the anchor of the match, prepend it to the path info.
+                                if ( ! empty($req_uri) && strpos($match, $req_uri) === 0 && $req_uri != $request )
+                                        $request_match = $req_uri . '/' . $request;
+
+                                if ( preg_match("#^$match#", $request_match, $matches) ||
+                                        preg_match("#^$match#", urldecode($request_match), $matches) ) {
+
+                                        if ( $this->use_verbose_page_rules && preg_match( '/pagename=\$matches\[([0-9]+)\]/', $query, $varmatch ) ) {
+                                                // This is a verbose page match, let's check to be sure about it.
+                                                $page = get_page_by_path( $matches[ $varmatch[1] ] );
+                                                if ( ! $page ) {
+                                                        continue;
+                                                }
+
+                                                $post_status_obj = get_post_status_object( $page->post_status );
+                                                if ( ! $post_status_obj->public && ! $post_status_obj->protected
+                                                        && ! $post_status_obj->private && $post_status_obj->exclude_from_search ) {
+                                                        continue;
+                                                }
+                                        }
+
+                                        // Got a match.
+                                        $found_match = true;
+                                        break;
+                                }
+                        }
+                }
+
+                if ( $found_match ) {
+                        // Trim the query of everything up to the '?'.
+                        $query = preg_replace("!^.+\?!", '', $query);
+
+                        // Substitute the substring matches into the query.
+                        $query = addslashes(WP_MatchesMapRegex::apply($query, $matches));
+
+                        return array( $match, $query );
+                } else {
+                        return false;
+                }
+        }
+
+        /**
          * Constructor - Calls init(), which runs setup.
          *
          * @since 1.5.0

src/wp-includes/class-wp.php

@@ -200 +200 @@
 
                         $this->request = $request;
 
-                        // Look for matches.
-                        $request_match = $request;
-                        if ( empty( $request_match ) ) {
-                                // An empty request could only match against ^$ regex
-                                if ( isset( $rewrite['$'] ) ) {
-                                        $this->matched_rule = '$';
-                                        $query = $rewrite['$'];
-                                        $matches = array('');
-                                }
-                        } else {
-                                foreach ( (array) $rewrite as $match => $query ) {
-                                        // If the requesting file is the anchor of the match, prepend it to the path info.
-                                        if ( ! empty($req_uri) && strpos($match, $req_uri) === 0 && $req_uri != $request )
-                                                $request_match = $req_uri . '/' . $request;
+                        $result = $wp_rewrite->find_match( $request, $req_uri, $rewrite );
 
-                                        if ( preg_match("#^$match#", $request_match, $matches) ||
-                                                preg_match("#^$match#", urldecode($request_match), $matches) ) {
+                        if ( $result ) {
+                                $this->matched_rule = $result[0];
+                                $this->matched_query = $result[1];
 
-                                                if ( $wp_rewrite->use_verbose_page_rules && preg_match( '/pagename=\$matches\[([0-9]+)\]/', $query, $varmatch ) ) {
-                                                        // This is a verbose page match, let's check to be sure about it.
-                                                        $page = get_page_by_path( $matches[ $varmatch[1] ] );
-                                                        if ( ! $page ) {
-                                                                continue;
-                                                        }
-
-                                                        $post_status_obj = get_post_status_object( $page->post_status );
-                                                        if ( ! $post_status_obj->public && ! $post_status_obj->protected
-                                                                && ! $post_status_obj->private && $post_status_obj->exclude_from_search ) {
-                                                                continue;
-                                                        }
-                                                }
-
-                                                // Got a match.
-                                                $this->matched_rule = $match;
-                                                break;
-                                        }
-                                }
-                        }
-
-                        if ( isset( $this->matched_rule ) ) {
-                                // Trim the query of everything up to the '?'.
-                                $query = preg_replace("!^.+\?!", '', $query);
-
-                                // Substitute the substring matches into the query.
-                                $query = addslashes(WP_MatchesMapRegex::apply($query, $matches));
-
-                                $this->matched_query = $query;
-
                                 // Parse the query.
-                                parse_str($query, $perma_query_vars);
+                                parse_str($this->matched_query, $perma_query_vars);
 
                                 // If we're processing a 404 request, clear the error var since we found something.
                                 if ( '404' == $error )

src/wp-includes/rewrite.php

@@ -538 +538 @@
         }
 
         // Look for matches.
-        $request_match = $request;
-        foreach ( (array)$rewrite as $match => $query) {
+        $result = $wp_rewrite->find_match( $request, $url, $rewrite );
+        if ( $result ) {
+                // Got a match.
+                $match = $result[0];
+                $query = $result[1];
 
-                // If the requesting file is the anchor of the match, prepend it
-                // to the path info.
-                if ( !empty($url) && ($url != $request) && (strpos($match, $url) === 0) )
-                        $request_match = $url . '/' . $request;
-
-                if ( preg_match("#^$match#", $request_match, $matches) ) {
-
-                        if ( $wp_rewrite->use_verbose_page_rules && preg_match( '/pagename=\$matches\[([0-9]+)\]/', $query, $varmatch ) ) {
-                                // This is a verbose page match, let's check to be sure about it.
-                                $page = get_page_by_path( $matches[ $varmatch[1] ] );
-                                if ( ! $page ) {
-                                        continue;
+                // Filter out non-public query vars
+                global $wp;
+                parse_str( $query, $query_vars );
+                $query = array();
+                foreach ( (array) $query_vars as $key => $value ) {
+                        if ( in_array( $key, $wp->public_query_vars ) ){
+                                $query[$key] = $value;
+                                if ( isset( $post_type_query_vars[$key] ) ) {
+                                        $query['post_type'] = $post_type_query_vars[$key];
+                                        $query['name'] = $value;
                                 }
-
-                                $post_status_obj = get_post_status_object( $page->post_status );
-                                if ( ! $post_status_obj->public && ! $post_status_obj->protected
-                                        && ! $post_status_obj->private && $post_status_obj->exclude_from_search ) {
-                                        continue;
-                                }
                         }
+                }
 
-                        // Got a match.
-                        // Trim the query of everything up to the '?'.
-                        $query = preg_replace("!^.+\?!", '', $query);
+                // Resolve conflicts between posts with numeric slugs and date archive queries.
+                $query = wp_resolve_numeric_slug_conflicts( $query );
 
-                        // Substitute the substring matches into the query.
-                        $query = addslashes(WP_MatchesMapRegex::apply($query, $matches));
-
-                        // Filter out non-public query vars
-                        global $wp;
-                        parse_str( $query, $query_vars );
-                        $query = array();
-                        foreach ( (array) $query_vars as $key => $value ) {
-                                if ( in_array( $key, $wp->public_query_vars ) ){
-                                        $query[$key] = $value;
-                                        if ( isset( $post_type_query_vars[$key] ) ) {
-                                                $query['post_type'] = $post_type_query_vars[$key];
-                                                $query['name'] = $value;
-                                        }
-                                }
-                        }
-
-                        // Resolve conflicts between posts with numeric slugs and date archive queries.
-                        $query = wp_resolve_numeric_slug_conflicts( $query );
-
-                        // Do the query
-                        $query = new WP_Query( $query );
-                        if ( ! empty( $query->posts ) && $query->is_singular )
-                                return $query->post->ID;
-                        else
-                                return 0;
-                }
+                // Do the query
+                $query = new WP_Query( $query );
+                if ( ! empty( $query->posts ) && $query->is_singular )
+                        return $query->post->ID;
+                else
+                        return 0;
         }
         return 0;
 }

tests/phpunit/tests/rewrite/findMatch.php

@@ +1 @@
+<?php
+
+/**
+ * @group rewrite
+ * @group failing
+ */
+class Tests_Rewrite_FindMatch extends WP_UnitTestCase {
+
+        public function test_find_match() {
+                global $wp_rewrite;
+
+                $rules = array(
+                        'page/?([0-9]{1,})/?$' => 'index.php?paged=$matches[1]',
+                        'search/(.+)/?$' => 'index.php?s=$matches[1]',
+                        'blog/author/([^/]+)/page/?([0-9]{1,})/?$' => 'index.php?author_name=$matches[1]&paged=$matches[2]',
+                        'blog/([0-9]{4})/([0-9]{1,2})/([0-9]{1,2})/?$' => 'index.php?year=$matches[1]&monthnum=$matches[2]&day=$matches[3]',
+                );
+
+                $match = $wp_rewrite->find_match( 'page/2', 'page/2', $rules );
+                $expected = 'paged=2';
+                $this->assertSame( $expected, $match[1] );
+
+                $match = $wp_rewrite->find_match( 'search/kombucha', 'search/kombucha', $rules );
+                $expected = 's=kombucha';
+                $this->assertSame( $expected, $match[1] );
+
+                $match = $wp_rewrite->find_match( 'blog/author/glerf/page/29', 'blog/author/glerf/page/29', $rules );
+                $expected = 'author_name=glerf&paged=29';
+                $this->assertSame( $expected, $match[1] );
+
+                $match = $wp_rewrite->find_match( 'blog/2015/06/29', 'blog/2015/06/29', $rules );
+                $expected = 'year=2015&monthnum=06&day=29';
+                $this->assertSame( $expected, $match[1] );
+        }
+
+        public function test_find_match_respects_order() {
+                global $wp_rewrite;
+
+                $rules = array(
+                        'page/?([0-9]{1,})/$' => 'index.php?&paged=$matches[1]',
+                        'page/?([0-9]{1,})/?$' => 'index.php?&paged=$matches[1]',
+                );
+
+                $match = $wp_rewrite->find_match( 'page/2/', 'page/2/', $rules );
+                $expected = 'page/?([0-9]{1,})/$';
+                $this->assertSame( $expected, $match[0] );
+        }
+
+        public function test_match_page_with_verbose_page_rules_on() {
+                $this->set_permalink_structure( '/%postname%/' );
+
+                global $wp_rewrite;
+
+                $page = self::factory()->post->create( array(
+                        'post_type' => 'page',
+                        'post_status' => 'publish',
+                        'post_name' => 'how-to-brew-kombucha',
+                ) );
+
+                $rules = array(
+                        '(.?.+?)(?:/([0-9]+))?/?$' => 'index.php?pagename=$matches[1]&page=$matches[2]',
+                        '([^/]+)(?:/([0-9]+))?/?$' => 'index.php?name=$matches[1]&page=$matches[2]',
+                );
+
+                $match = $wp_rewrite->find_match( 'how-to-brew-kombucha', 'how-to-brew-kombucha', $rules );
+                $expected = 'pagename=how-to-brew-kombucha&page=';
+                // var_dump( $match)
+                $this->assertSame( $expected, $match[1] );
+        }
+
+        public function test_skip_page_rule_that_doesnt_match_slug_with_verbose_page_rules_on() {
+                $this->set_permalink_structure( '/%postname%/' );
+
+                global $wp_rewrite;
+
+                $page = self::factory()->post->create( array(
+                        'post_type' => 'page',
+                        'post_status' => 'publish',
+                        'post_name' => 'how-to-brew-kombucha',
+                ) );
+
+                $rules = array(
+                        '(.?.+?)(?:/([0-9]+))?/?$' => 'index.php?pagename=$matches[1]&page=$matches[2]',
+                        '([^/]+)(?:/([0-9]+))?/?$' => 'index.php?name=$matches[1]&page=$matches[2]',
+                );
+
+                $match = $wp_rewrite->find_match( 'a-vertical-garden-design-for-urban-living', 'a-vertical-garden-design-for-urban-living', $rules );
+                $expected = 'name=a-vertical-garden-design-for-urban-living&page=';
+                $this->assertSame( $expected, $match[1] );
+        }
+
+        public function test_skip_page_rule_for_a_trashed_page_with_verbose_page_rules_on() {
+                $this->set_permalink_structure( '/%postname%/' );
+
+                global $wp_rewrite;
+
+                $trashed_page = self::factory()->post->create( array(
+                        'post_type' => 'page',
+                        'post_status' => 'trash',
+                        'post_name' => 'how-to-brew-kombucha',
+                ) );
+
+                $post = self::factory()->post->create( array(
+                        'post_type' => 'post',
+                        'post_status' => 'publish',
+                        'post_name' => 'how-to-brew-kombucha',
+                ) );
+
+                $rules = array(
+                        '(.?.+?)(?:/([0-9]+))?/?$' => 'index.php?pagename=$matches[1]&page=$matches[2]',
+                        '([^/]+)(?:/([0-9]+))?/?$' => 'index.php?name=$matches[1]&page=$matches[2]',
+                );
+
+                $match = $wp_rewrite->find_match( 'how-to-brew-kombucha', 'how-to-brew-kombucha', $rules );
+                $expected = 'name=how-to-brew-kombucha&page=';
+                $this->assertSame( $expected, $match[1] );
+        }
+}