WordPress.org

Make WordPress Core

Ticket #18900: 18900-header-bg.2.diff

File 18900-header-bg.2.diff, 1.8 KB (added by DrewAPicture, 6 years ago)

Simplifies the UI, no empty space if no-js

  • wp-admin/custom-header.php

     
    538538                $image_library_url = remove_query_arg( 'TB_iframe', $image_library_url );
    539539                $image_library_url = add_query_arg( array( 'context' => 'custom-header', 'TB_iframe' => 1 ), $image_library_url );
    540540        ?>
    541         <p>
     541        <p class="hide-if-no-js">
    542542                <label for="choose-from-library-link"><?php _e( 'Or choose an image from your media library:' ); ?></label><br />
    543543                <a id="choose-from-library-link" class="button thickbox" href="<?php echo esc_url( $image_library_url ); ?>"><?php _e( 'Choose Image' ); ?></a>
    544544        </p>
     545        <p class="hide-if-js">
     546                <strong><?php _e( 'You need Javascript to choose a header image from the Media Library.' ); ?></strong>
     547        </p>
    545548        </form>
    546549</td>
    547550</tr>
  • wp-admin/custom-background.php

     
    267267                $image_library_url = remove_query_arg( 'TB_iframe', $image_library_url );
    268268                $image_library_url = add_query_arg( array( 'context' => 'custom-background', 'TB_iframe' => 1 ), $image_library_url );
    269269        ?>
    270         <p>
     270        <p class="hide-if-no-js">
    271271                <label for="choose-from-library-link"><?php _e( 'Or choose an image from your media library:' ); ?></label><br />
    272272                <a id="choose-from-library-link" class="button thickbox" href="<?php echo esc_url( $image_library_url ); ?>"><?php _e( 'Choose Image' ); ?></a>
    273273        </p>
     274        <p class="hide-if-js">
     275                <strong><?php _e( 'You need Javascript to choose a background image from the Media Library.' ); ?></strong>
     276        </p>
    274277        </form>
    275278</td>
    276279</tr>