Ticket #21523: 21523.4.patch

wp-admin/credits.php

@@ -37 +37 @@
 
                 $results = json_decode( wp_remote_retrieve_body( $response ), true );
 
-                if ( ! is_array( $results ) )
+                if ( ! is_array( $results ) ){
                         return false;
+                }
 
+                if ( empty( $results['groups'] ) || !is_array( $results['groups'] ) ){
+                        return false;
+                } else {
+                        foreach ( $results['groups'] as $group_slug => $group_data ) {
+                                if ( empty( $group_data['name'] ) 
+                                         && 'contributing-developers' !== $group_slug
+                                         && 'recent-rockstars' !== $group_slug ){
+                                        return false;
+                                } elseif ( empty( $group_data['type'] ) ){
+                                        return false;
+                                } elseif ( empty( $group_data['data'] ) ){
+                                        return false;
+                                }
+                        }
+                }
+
+                if ( empty( $results['data'] ) || !is_array( $results['data'] ) ){
+                        return false;
+                } elseif (              empty( $results['data']['profiles'] ) 
+                                        ||  empty( $results['data']['version'] ) 
+                                        || !is_string( $results['data']['profiles'] )
+                                        || !is_string( $results['data']['version'] ) ) {
+                        return false;
+                }
+
                 set_site_transient( 'wordpress_credits_' . $locale, $results, DAY_IN_SECONDS );
         }
 
@@ -71 +97 @@
  * @return string Link to the external library.
  */
 function _wp_credits_build_object_link( &$data ) {
-        $data = '<a href="' . esc_url( $data[1] ) . '">' . $data[0] . '</a>';
+        $data = '<a href="' . esc_url( $data[1] ) . '">' . esc_html( $data[0] ) . '</a>';
 }
 
 list( $display_version ) = explode( '-', $wp_version );
@@ -80 +106 @@
 ?>
 <div class="wrap about-wrap">
 
-<h1><?php printf( __( 'Welcome to WordPress %s' ), $display_version ); ?></h1>
+<h1><?php printf( __( 'Welcome to WordPress %s' ), esc_html( $display_version ) ); ?></h1>
 
-<div class="about-text"><?php printf( __( 'Thank you for updating! WordPress %s helps you communicate and share, globally.' ), $display_version ); ?></div>
+<div class="about-text"><?php printf( __( 'Thank you for updating! WordPress %s helps you communicate and share, globally.' ), esc_html( $display_version ) ); ?></div>
 
-<div class="wp-badge"><?php printf( __( 'Version %s' ), $display_version ); ?></div>
+<div class="wp-badge"><?php printf( __( 'Version %s' ), esc_html( $display_version ) ); ?></div>
 
 <h2 class="nav-tab-wrapper">
         <a href="about.php" class="nav-tab">
@@ -101 +127 @@
 $credits = wp_credits();
 
 if ( ! $credits ) {
-        echo '<p class="about-description">' . sprintf( __( 'WordPress is created by a <a href="%1$s">worldwide team</a> of passionate individuals. <a href="%2$s">Get involved in WordPress</a>.' ),
+        echo '<p class="about-description">' . esc_html( sprintf( __( 'WordPress is created by a <a href="%1$s">worldwide team</a> of passionate individuals. <a href="%2$s">Get involved in WordPress</a>.' ),
                 'https://wordpress.org/about/',
                 /* translators: Url to the codex documentation on contributing to WordPress used on the credits page */
-                __( 'https://codex.wordpress.org/Contributing_to_WordPress' ) ) . '</p>';
+                __( 'https://codex.wordpress.org/Contributing_to_WordPress' ) ) ) . '</p>';
         include( ABSPATH . 'wp-admin/admin-footer.php' );
         exit;
 }
@@ -124 +150 @@
                         $title = translate( $group_data['name'] );
                 }
 
-                echo '<h4 class="wp-people-group">' . $title . "</h4>\n";
+                echo '<h4 class="wp-people-group">' . esc_html( $title ) . "</h4>\n";
         }
 
         if ( ! empty( $group_data['shuffle'] ) )
@@ -141 +167 @@
                         break;
                 default:
                         $compact = 'compact' == $group_data['type'];
-                        $classes = 'wp-people-group ' . ( $compact ? 'compact' : '' );
+                        $classes = esc_attr( 'wp-people-group ' . ( $compact ? 'compact' : '' ) );
                         echo '<ul class="' . $classes . '" id="wp-people-group-' . $group_slug . '">' . "\n";
                         foreach ( $group_data['data'] as $person_data ) {
-                                echo '<li class="wp-person" id="wp-person-' . $person_data[2] . '">' . "\n\t";
-                                echo '<a href="' . sprintf( $credits['data']['profiles'], $person_data[2] ) . '">';
-                                $size = 'compact' == $group_data['type'] ? '30' : '60';
-                                echo '<img src="' . $gravatar . $person_data[1] . '?s=' . $size . '" srcset="' . $gravatar . $person_data[1] . '?s=' . $size * 2 . ' 2x" class="gravatar" alt="' . esc_attr( $person_data[0] ) . '" /></a>' . "\n\t";
-                                echo '<a class="web" href="' . sprintf( $credits['data']['profiles'], $person_data[2] ) . '">' . $person_data[0] . "</a>\n\t";
-                                if ( ! $compact )
-                                        echo '<span class="title">' . translate( $person_data[3] ) . "</span>\n";
-                                echo "</li>\n";
+                                if (    isset( $person_data[0]  ) 
+                                         && isset( $person_data[1]  ) 
+                                         && isset( $person_data[2]  ) ){
+                                        echo '<li class="wp-person" id="wp-person-' . esc_attr( $person_data[2] ) . '">' . "\n\t";
+                                        echo '<a href="' . esc_url( sprintf( $credits['data']['profiles'], $person_data[2] ) ) . '">';
+                                        $size = 'compact' == $group_data['type'] ? '30' : '60';
+                                        echo '<img src="' . esc_url( $gravatar . $person_data[1] . '?s=' . $size . '" srcset="' . $gravatar . $person_data[1] . '?s=' . $size * 2 ) . ' 2x" class="gravatar" alt="' . esc_attr( $person_data[0] ) . '" /></a>' . "\n\t";
+                                        echo '<a class="web" href="' . esc_url( sprintf( $credits['data']['profiles'], $person_data[2] ) ) . '">' . esc_html( $person_data[0] ) . "</a>\n\t";
+                                        if ( ! $compact && isset( $person_data[3] ) ){
+                                                echo '<span class="title">' . esc_html( translate( $person_data[3] ) ) . "</span>\n";
+                                        }
+                                        echo "</li>\n";
+                                }
                         }
                         echo "</ul>\n";
                 break;