Ticket #21523: 21523.5.patch

src/wp-admin/credits.php

@@ -69 +69 @@
  * @param string &$data External library data, passed by reference.
  */
 function _wp_credits_build_object_link( &$data ) {
-        $data = '<a href="' . esc_url( $data[1] ) . '">' . $data[0] . '</a>';
+        $data = '<a href="' . esc_url( $data[1] ) . '">' . esc_html( $data[0] ) . '</a>';
 }
 
 list( $display_version ) = explode( '-', $wp_version );
@@ -78 +78 @@
 ?>
 <div class="wrap about-wrap">
 
-<h1><?php printf( __( 'Welcome to WordPress %s' ), $display_version ); ?></h1>
+<h1><?php printf( __( 'Welcome to WordPress %s' ), esc_html( $display_version ) ); ?></h1>
 
-<div class="about-text"><?php printf( __( 'Thank you for updating! WordPress %s helps you communicate and share, globally.' ), $display_version ); ?></div>
+<div class="about-text"><?php printf( __( 'Thank you for updating! WordPress %s helps you communicate and share, globally.' ), esc_html( $display_version ) ); ?></div>
 
-<div class="wp-badge"><?php printf( __( 'Version %s' ), $display_version ); ?></div>
+<div class="wp-badge"><?php printf( __( 'Version %s' ), esc_html( $display_version ) ); ?></div>
 
 <h2 class="nav-tab-wrapper">
         <a href="about.php" class="nav-tab">
@@ -99 +99 @@
 $credits = wp_credits();
 
 if ( ! $credits ) {
-        echo '<p class="about-description">' . sprintf( __( 'WordPress is created by a <a href="%1$s">worldwide team</a> of passionate individuals. <a href="%2$s">Get involved in WordPress</a>.' ),
+        echo '<p class="about-description">' . esc_html( sprintf( __( 'WordPress is created by a <a href="%1$s">worldwide team</a> of passionate individuals. <a href="%2$s">Get involved in WordPress</a>.' ),
                 'https://wordpress.org/about/',
                 /* translators: Url to the codex documentation on contributing to WordPress used on the credits page */
-                __( 'https://codex.wordpress.org/Contributing_to_WordPress' ) ) . '</p>';
+                __( 'https://codex.wordpress.org/Contributing_to_WordPress' ) ) ) . '</p>';
         include( ABSPATH . 'wp-admin/admin-footer.php' );
         exit;
 }
@@ -120 +120 @@
                         $title = translate( $group_data['name'] );
                 }
 
-                echo '<h4 class="wp-people-group">' . $title . "</h4>\n";
+                echo '<h4 class="wp-people-group">' . esc_html( $title ) . "</h4>\n";
         }
 
         if ( ! empty( $group_data['shuffle'] ) )
@@ -138 +138 @@
                 default:
                         $compact = 'compact' == $group_data['type'];
                         $classes = 'wp-people-group ' . ( $compact ? 'compact' : '' );
-                        echo '<ul class="' . $classes . '" id="wp-people-group-' . $group_slug . '">' . "\n";
+                        echo '<ul class="' . esc_attr( $classes ) . '" id="wp-people-group-' . $group_slug . '">' . "\n";
                         foreach ( $group_data['data'] as $person_data ) {
-                                echo '<li class="wp-person" id="wp-person-' . $person_data[2] . '">' . "\n\t";
-                                echo '<a href="' . sprintf( $credits['data']['profiles'], $person_data[2] ) . '">';
+                                echo '<li class="wp-person" id="wp-person-' . esc_attr( $person_data[2] ) . '">' . "\n\t";
+                                echo '<a href="' . esc_url( sprintf( $credits['data']['profiles'], $person_data[2] ) ) . '">';
                                 $size = 'compact' == $group_data['type'] ? 30 : 60;
                                 $data = get_avatar_data( $person_data[1] . '@md5.gravatar.com', array( 'size' => $size ) );
                                 $size *= 2;
                                 $data2x = get_avatar_data( $person_data[1] . '@md5.gravatar.com', array( 'size' => $size ) );
-                                echo '<img src="' . esc_attr( $data['url'] ) . '" srcset="' . esc_attr( $data2x['url'] ) . ' 2x" class="gravatar" alt="' . esc_attr( $person_data[0] ) . '" /></a>' . "\n\t";
-                                echo '<a class="web" href="' . sprintf( $credits['data']['profiles'], $person_data[2] ) . '">' . $person_data[0] . "</a>\n\t";
+                                echo '<img src="' . esc_url( $data['url'] ) . '" srcset="' . esc_attr( $data2x['url'] ) . ' 2x" class="gravatar" alt="' . esc_attr( $person_data[0] ) . '" /></a>' . "\n\t";
+                                echo '<a class="web" href="' . esc_url( sprintf( $credits['data']['profiles'], $person_data[2] ) ) . '">' . esc_html( $person_data[0] ) . "</a>\n\t";
                                 if ( ! $compact )
-                                        echo '<span class="title">' . translate( $person_data[3] ) . "</span>\n";
+                                        echo '<span class="title">' . esc_html( translate( $person_data[3] ) ) . "</span>\n";
                                 echo "</li>\n";
                         }
                         echo "</ul>\n";