Ticket #21790: 21790.diff

tests/phpunit/tests/query.php

@@ -2 +2 @@
 
 class Tests_Query extends WP_UnitTestCase {
 
+        /**
+         *
+         * @var bool 
+         */
+        var $test_error = false;
+
         function setUp() {
                 global $wp_rewrite;
                 parent::setUp();
@@ -133 +139 @@
 
                 $this->assertContains( "ORDER BY $wpdb->posts.post_title DESC, $wpdb->posts.post_date DESC", $q->request );
         }
+        
+        /**
+         * Tests to see if the pre_get_posts filter causes PHP notices when run on a static front page.
+         * @ticket 21790
+         */
+        function test_static_front_page_pre_get_posts() {
+                add_filter( 'pre_get_posts', array( $this, 'filter_static_front_page_pre_get_posts' ) );
+                $page_one        = $this->factory->post->create( array( 'post_type' => 'page' ) );
+                $page_two        = $this->factory->post->create( array( 'post_type' => 'page' ) );
+                update_option( 'show_on_front', 'page' );
+                update_option( 'page_on_front', $page_one );
+                $this->go_to( home_url() );
+                $this->assertFalse( $this->test_error, 'PHP Notices on front page.' );
+
+                // Run same test on page that is not set as front page.
+                $this->test_error = false;
+                $this->go_to( get_permalink( $page_two ) );
+                $this->assertFalse( $this->test_error, 'PHP Notices on another page.' );
 }
+
+        /**
+         * Callback for pre_get_posts filter that tries to catch PHP notice.
+         * @param WP_Query $query
+         * @return WP_Query
+         */
+        function filter_static_front_page_pre_get_posts( $query ) {
+                try {
+                        if ( $query->is_main_query() && is_front_page() ) {
+                                
+                        }
+                } catch ( Exception $e ) {
+                        $this->test_error = true;
+                }
+
+                return $query;
+        }
+
+}