Ticket #21963: 21963.6.diff

src/wp-includes/post.php

@@ -3243 +3243 @@
                         $wpdb->update( $wpdb->posts, array( 'guid' => get_permalink( $post_ID ) ), $where );
                 }
         } else {
-                if ( isset( $postarr['file'] ) ) {
+                if ( ! empty( $postarr['file'] ) ) {
                         update_attached_file( $post_ID, $postarr['file'] );
                 }
 

tests/phpunit/tests/post/attachments.php

@@ -231 +231 @@
                 $this->assertFalse( empty( $guid ) );
         }
 
+        /**
+         * @ticket 21963
+         */
+        function test_update_attachment_fields() {
+                $filename = ( DIR_TESTDATA . '/images/test-image.jpg' );
+                $contents = file_get_contents($filename);
+
+                $upload = wp_upload_bits( basename( $filename ), null, $contents );
+                $this->assertTrue( empty( $upload['error'] ) );
+
+                $id = $this->_make_attachment( $upload );
+
+                $attached_file = get_post_meta( $id, '_wp_attached_file', true );
+
+                $post = get_post( $id, ARRAY_A );
+
+                $post['post_title'] = 'title';
+                $post['post_excerpt'] = 'caption';
+                $post['post_content'] = 'description';
+
+                wp_update_post( $post );
+
+                // Make sure the update didn't remove the attached file.
+                $this->assertEquals( $attached_file, get_post_meta( $id, '_wp_attached_file', true ) );
+        }
+
 }