Ticket #22212: 22212.3.diff

src/wp-includes/class-wp-user-query.php

@@ -304 +304 @@
                                 foreach ( $roles as $role ) {
                                         $roles_clauses[] = array(
                                                 'key'     => $wpdb->get_blog_prefix( $blog_id ) . 'capabilities',
-                                                'value'   => $role,
+                                                'value'   => '"' . $role . '"',
                                                 'compare' => 'LIKE',
                                         );
                                 }
@@ -317 +317 @@
                                 foreach ( $role__in as $role ) {
                                         $role__in_clauses[] = array(
                                                 'key'     => $wpdb->get_blog_prefix( $blog_id ) . 'capabilities',
-                                                'value'   => $role,
+                                                'value'   => '"' . $role . '"',
                                                 'compare' => 'LIKE',
                                         );
                                 }
@@ -330 +330 @@
                                 foreach ( $role__not_in as $role ) {
                                         $role__not_in_clauses[] = array(
                                                 'key'     => $wpdb->get_blog_prefix( $blog_id ) . 'capabilities',
-                                                'value'   => $role,
+                                                'value'   => '"' . $role . '"',
                                                 'compare' => 'NOT LIKE',
                                         );
                                 }

tests/phpunit/tests/user/query.php

@@ -958 +958 @@
         /**
          * @ticket 22212
          */
+        public function test_get_single_role_by_string_which_is_similar() {
+                $this->factory->user->create_many( 2, array(
+                        'role' => 'editor',
+                ) );
+
+                $this->factory->user->create( array(
+                        'role' => 'another-editor',
+                ) );
+
+                $users = get_users( array(
+                        'role' => 'editor',
+                ) );
+
+                $this->assertEquals( 2, count( $users ) );
+        }
+
+
+        /**
+         * @ticket 22212
+         */
         public function test_get_single_role_by_array() {
                 $this->factory->user->create_many( 2, array(
                         'role' => 'subscriber',