Ticket #22400: 22400.author-template.php.diff

wp-includes/author-template.php

@@ -275 +275 @@
         );
 
         $args = wp_parse_args( $args, $defaults );
-        extract( $args, EXTR_SKIP );
 
         $return = '';
 
@@ -290 +289 @@
         foreach ( $authors as $author_id ) {
                 $author = get_userdata( $author_id );
 
-                if ( $exclude_admin && 'admin' == $author->display_name )
+                if ( $args['exclude_admin'] && 'admin' == $author->display_name )
                         continue;
 
                 $posts = isset( $author_count[$author->ID] ) ? $author_count[$author->ID] : 0;
 
-                if ( !$posts && $hide_empty )
+                if ( !$posts && $args['hide_empty'] )
                         continue;
 
                 $link = '';
 
-                if ( $show_fullname && $author->first_name && $author->last_name )
+                if ( $args['show_fullname'] && $author->first_name && $author->last_name )
                         $name = "$author->first_name $author->last_name";
                 else
                         $name = $author->display_name;
 
-                if ( !$html ) {
+                if ( !$args['html'] ) {
                         $return .= $name . ', ';
 
                         continue; // No need to go further to process HTML.
                 }
 
-                if ( 'list' == $style ) {
+                if ( 'list' == $args['style'] ) {
                         $return .= '<li>';
                 }
 
                 $link = '<a href="' . get_author_posts_url( $author->ID, $author->user_nicename ) . '" title="' . esc_attr( sprintf(__("Posts by %s"), $author->display_name) ) . '">' . $name . '</a>';
 
-                if ( !empty( $feed_image ) || !empty( $feed ) ) {
+                if ( !empty( $args['feed_image'] ) || !empty( $args['feed'] ) ) {
                         $link .= ' ';
-                        if ( empty( $feed_image ) ) {
+                        if ( empty( $args['feed_image'] ) ) {
                                 $link .= '(';
                         }
 
                         $link .= '<a href="' . get_author_feed_link( $author->ID ) . '"';
 
                         $alt = $title = '';
-                        if ( !empty( $feed ) ) {
-                                $title = ' title="' . esc_attr( $feed ) . '"';
-                                $alt = ' alt="' . esc_attr( $feed ) . '"';
-                                $name = $feed;
+                        if ( !empty( $args['feed'] ) ) {
+                                $title = ' title="' . esc_attr( $args['feed'] ) . '"';
+                                $alt = ' alt="' . esc_attr( $args['feed'] ) . '"';
+                                $name = $args['feed'];
                                 $link .= $title;
                         }
 
                         $link .= '>';
 
-                        if ( !empty( $feed_image ) )
-                                $link .= '<img src="' . esc_url( $feed_image ) . '" style="border: none;"' . $alt . $title . ' />';
+                        if ( !empty( $args['feed_image'] ) )
+                                $link .= '<img src="' . esc_url( $args['feed_image'] ) . '" style="border: none;"' . $alt . $title . ' />';
                         else
                                 $link .= $name;
 
                         $link .= '</a>';
 
-                        if ( empty( $feed_image ) )
+                        if ( empty( $args['feed_image'] ) )
                                 $link .= ')';
                 }
 
-                if ( $optioncount )
+                if ( $args['optioncount'] )
                         $link .= ' ('. $posts . ')';
 
                 $return .= $link;
-                $return .= ( 'list' == $style ) ? '</li>' : ', ';
+                $return .= ( 'list' == $args['style'] ) ? '</li>' : ', ';
         }
 
         $return = rtrim($return, ', ');
 
-        if ( !$echo )
+        if ( !$args['echo'] )
                 return $return;
 
         echo $return;